third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp - Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compilation. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/LocalFileSystemClient.cpp ('k') | third_party/WebKit/Source/web/PageOverlay.cpp » ('j') | third_party/WebKit/Source/web/TextFinder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp b/third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp

index 9334e3f8851cd07f7ca8031d9332bf8445e3712d..d3f0c039cbf9b4c706f0a92a2ce78357a7183b4d 100644

--- a/third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp

+++ b/third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp

@@ -59,10 +59,10 @@ NotificationPermissionClientImpl::~NotificationPermissionClientImpl()

ScriptPromise NotificationPermissionClientImpl::requestPermission(ScriptState* scriptState, NotificationPermissionCallback* deprecatedCallback)

{

- ASSERT(scriptState);

+ DCHECK(scriptState);

ExecutionContext* context = scriptState->getExecutionContext();

- ASSERT(context && context->isDocument());

+ DCHECK(context && context->isDocument());

tkent 2016/03/31 23:05:21 Please split this into two. DCHECK(context);

Document* document = toDocument(context);

WebLocalFrameImpl* webFrame = WebLocalFrameImpl::fromFrame(document->frame());