third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp - Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compilation. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/FindInPageCoordinates.cpp ('k') | third_party/WebKit/Source/web/FullscreenController.cpp » ('j') | third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

index 3250066ef3ce13fe2795ee1d2cdae5cc62b159a2..ec47ce68b27097add573319ba42e74c4ea2ef0ed 100644

--- a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

+++ b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

@@ -659,7 +659,7 @@ void FrameLoaderClientImpl::loadURLExternally(const ResourceRequest& request, Na

{

if (!m_webFrame->client())

return;

- ASSERT(m_webFrame->frame()->document());

+ DCHECK(m_webFrame->frame()->document());

Fullscreen::fullyExitFullscreen(*m_webFrame->frame()->document());

m_webFrame->client()->loadURLExternally(

WrappedResourceRequest(request), static_cast<WebNavigationPolicy>(policy), suggestedName, shouldReplaceCurrentEntry);

@@ -671,7 +671,7 @@ bool FrameLoaderClientImpl::navigateBackForward(int offset) const

if (!webview->client())

return false;

- ASSERT(offset);

+ DCHECK(offset);

if (offset > webview->client()->historyForwardListCount())

return false;

if (offset < -webview->client()->historyBackListCount())

@@ -932,7 +932,7 @@ void FrameLoaderClientImpl::didUpdateToUniqueOrigin()

{

if (!m_webFrame->client())

return;

- ASSERT(m_webFrame->getSecurityOrigin().isUnique());

+ DCHECK(m_webFrame->getSecurityOrigin().isUnique());

m_webFrame->client()->didUpdateToUniqueOrigin(m_webFrame->getSecurityOrigin().isPotentiallyTrustworthy());

}