third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp - Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compilation. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/DragClientImpl.cpp ('k') | third_party/WebKit/Source/web/FindInPageCoordinates.cpp » ('j') | third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp

diff --git a/third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp b/third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp

index 9c3be66ed870575bd5d56e5aafca9f7bf0c6aa0a..bfa2599effe5a241c79bd3bc3bc198cfacf3130f 100644

--- a/third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp

+++ b/third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp

@@ -78,12 +78,12 @@ DEFINE_TRACE(ExternalDateTimeChooser)

ExternalDateTimeChooser::ExternalDateTimeChooser(DateTimeChooserClient* client)

: m_client(client)

{

- ASSERT(client);

+ DCHECK(client);

}

PassRefPtrWillBeRawPtr<ExternalDateTimeChooser> ExternalDateTimeChooser::create(ChromeClientImpl* chromeClient, WebViewClient* webViewClient, DateTimeChooserClient* client, const DateTimeChooserParameters& parameters)

{

- ASSERT(chromeClient);

+ DCHECK(chromeClient);

RefPtrWillBeRawPtr<ExternalDateTimeChooser> chooser = adoptRefWillBeNoop(new ExternalDateTimeChooser(client));

if (!chooser->openDateTimeChooser(chromeClient, webViewClient, parameters))

chooser.clear();