third_party/WebKit/Source/web/DateTimeChooserImpl.cpp - Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/DateTimeChooserImpl.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compilation. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/DatabaseClientImpl.cpp ('k') | third_party/WebKit/Source/web/DragClientImpl.cpp » ('j') | third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/DateTimeChooserImpl.cpp

diff --git a/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp b/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp

index 49aa97e5f8011ef04eea7e6ea03f3e7b431ef86b..e7f023569304ae09f17c5266338572d1888844b2 100644

--- a/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp

+++ b/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp

@@ -52,8 +52,8 @@ DateTimeChooserImpl::DateTimeChooserImpl(ChromeClientImpl* chromeClient, DateTim

, m_parameters(parameters)

, m_locale(Locale::create(parameters.locale))

{

- ASSERT(m_chromeClient);

- ASSERT(m_client);

+ DCHECK(m_chromeClient);

+ DCHECK(m_client);

m_popup = m_chromeClient->openPagePopup(this);

}

@@ -205,7 +205,7 @@ void DateTimeChooserImpl::closePopup()

void DateTimeChooserImpl::didClosePopup()

{

- ASSERT(m_client);

+ DCHECK(m_client);

m_popup = nullptr;

m_client->didEndChooser();

}