Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 835c19d3ddbc0225aa5affdaaee3c9f732a242ac..ab618ab043a40f5843e3d7b872c5de40c1934b57 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -257,7 +257,7 @@ protected:
webViewHelper->initializeAndLoad(m_baseURL + "nodeimage.html");
webViewHelper->resize(WebSize(640, 480));
RawPtr<LocalFrame> frame = toLocalFrame(webViewHelper->webViewImpl()->page()->mainFrame());
- ASSERT(frame);
+ DCHECK(frame);
Element* element = frame->document()->getElementById(testcase.c_str());
return frame->nodeImage(*element);
}
@@ -265,7 +265,7 @@ protected:
void removeElementById(WebLocalFrameImpl* frame, const AtomicString& id)
{
Element* element = frame->frame()->document()->getElementById(id);
- ASSERT(element);
+ DCHECK(element);
element->remove();
}
@@ -5972,7 +5972,7 @@ public:
virtual WebFrame* createChildFrame(WebLocalFrame* parent, WebTreeScopeType scope, const WebString&, const WebString&, WebSandboxFlags, const WebFrameOwnerProperties& frameOwnerProperties)
{
- ASSERT(m_childClient);
+ DCHECK(m_childClient);
m_childFrameCreationCount++;
WebFrame* frame = WebLocalFrame::create(scope, m_childClient);
parent->appendChild(frame);

Powered by Google App Engine
This is Rietveld 408576698