third_party/WebKit/Source/web/tests/VisualViewportTest.cpp - Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp ('k') | third_party/WebKit/Source/web/tests/WebDocumentTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

index 260d46f9994d32c141d1da1b0140ff411f9da9c4..b400edc6827a10b9c60692b6e61f5a51fa869246 100644

--- a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

+++ b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

@@ -151,8 +151,8 @@ public:

WebLayer* getRootScrollLayer()

{

PaintLayerCompositor* compositor = frame()->contentLayoutObject()->compositor();

- ASSERT(compositor);

- ASSERT(compositor->scrollLayer());

+ DCHECK(compositor);

+ DCHECK(compositor->scrollLayer());

WebLayer* webScrollLayer = compositor->scrollLayer()->platformLayer();

return webScrollLayer;

@@ -1701,7 +1701,7 @@ TEST_P(ParameterizedVisualViewportTest, WindowDimensionsOnLoad)

navigateTo(m_baseURL + "window_dimensions.html");

Element* output = frame()->document()->getElementById("output");

- ASSERT(output);

+ DCHECK(output);

EXPECT_EQ(std::string("1600x1200"), std::string(output->innerHTML().ascii().data()));

}

@@ -1717,7 +1717,7 @@ TEST_P(ParameterizedVisualViewportTest, WindowDimensionsOnLoadWideContent)

navigateTo(m_baseURL + "window_dimensions_wide_div.html");

Element* output = frame()->document()->getElementById("output");

- ASSERT(output);

+ DCHECK(output);

EXPECT_EQ(std::string("2000x1500"), std::string(output->innerHTML().ascii().data()));

}