Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp b/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
index abf6665d326ab5602be402d9b81f1b9ccd3dc94a..286f930354a06d5717b78d15910f8ecb1c3a9b40 100644
--- a/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
+++ b/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
@@ -92,7 +92,7 @@ WebSharedWorkerImpl::WebSharedWorkerImpl(WebSharedWorkerClient* client)
WebSharedWorkerImpl::~WebSharedWorkerImpl()
{
- ASSERT(m_webView);
+ DCHECK(m_webView);
// Detach the client before closing the view to avoid getting called back.
m_mainFrame->setClient(0);
@@ -124,7 +124,7 @@ void WebSharedWorkerImpl::initializeLoader()
// Create 'shadow page'. This page is never displayed, it is used to proxy the
// loading requests from the worker context to the rest of WebKit and Chromium
// infrastructure.
- ASSERT(!m_webView);
+ DCHECK(!m_webView);
m_webView = WebView::create(0);
// FIXME: http://crbug.com/363843. This needs to find a better way to
// not create graphics layers.
@@ -168,8 +168,8 @@ void WebSharedWorkerImpl::willSendRequest(
void WebSharedWorkerImpl::didFinishDocumentLoad(WebLocalFrame* frame)
{
- ASSERT(!m_loadingDocument);
- ASSERT(!m_mainScriptLoader);
+ DCHECK(!m_loadingDocument);
+ DCHECK(!m_mainScriptLoader);
m_networkProvider = adoptPtr(m_client->createServiceWorkerNetworkProvider(frame->dataSource()));
m_mainScriptLoader = WorkerScriptLoader::create();
m_mainScriptLoader->setRequestContext(WebURLRequest::RequestContextSharedWorker);
@@ -305,8 +305,8 @@ void WebSharedWorkerImpl::didReceiveScriptLoaderResponse()
void WebSharedWorkerImpl::onScriptLoaderFinished()
{
- ASSERT(m_loadingDocument);
- ASSERT(m_mainScriptLoader);
+ DCHECK(m_loadingDocument);
+ DCHECK(m_mainScriptLoader);
if (m_askedToTerminate)
return;
if (m_mainScriptLoader->failed()) {
« no previous file with comments | « third_party/WebKit/Source/web/WebSettingsImpl.cpp ('k') | third_party/WebKit/Source/web/WebSpeechRecognitionResult.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698