third_party/WebKit/Source/web/WebSelection.cpp - Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebSelection.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/WebScopedWindowFocusAllowedIndicator.cpp ('k') | third_party/WebKit/Source/web/WebSettingsImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebSelection.cpp

diff --git a/third_party/WebKit/Source/web/WebSelection.cpp b/third_party/WebKit/Source/web/WebSelection.cpp

index b30d42b26ae781ac07b42a32e324c4a078491ae5..f043d2e3251c58cb21bd5220099116dcf2ff4a91 100644

--- a/third_party/WebKit/Source/web/WebSelection.cpp

+++ b/third_party/WebKit/Source/web/WebSelection.cpp

@@ -11,9 +11,9 @@ namespace blink {

static WebSelectionBound getWebSelectionBound(const CompositedSelection& selection, bool isStart)

{

- ASSERT(selection.type != NoSelection);

+ DCHECK_NE(selection.type, NoSelection);

const CompositedSelectionBound& bound = isStart ? selection.start : selection.end;

- ASSERT(bound.layer);

+ DCHECK(bound.layer);

WebSelectionBound::Type type = WebSelectionBound::Caret;

if (selection.type == RangeSelection) {