third_party/WebKit/Source/web/WebGeolocationPermissionRequestManager.cpp - Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebGeolocationPermissionRequestManager.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/WebGeolocationPermissionRequestManager.cpp

diff --git a/third_party/WebKit/Source/web/WebGeolocationPermissionRequestManager.cpp b/third_party/WebKit/Source/web/WebGeolocationPermissionRequestManager.cpp

index 3badcc3d10fb2871b7310c496c013d4c9961da8b..cc221d91d8f6a1f568b2499398b45ff1ab9d5361 100644

--- a/third_party/WebKit/Source/web/WebGeolocationPermissionRequestManager.cpp

+++ b/third_party/WebKit/Source/web/WebGeolocationPermissionRequestManager.cpp

@@ -51,7 +51,7 @@ int WebGeolocationPermissionRequestManager::add(const WebGeolocationPermissionRe

{

Geolocation* geolocation = permissionRequest.geolocation();

WebGeolocationPermissionRequestManagerPrivate* manager = ensureManager();

- ASSERT(!manager->m_geolocationIdMap.contains(geolocation));

+ DCHECK(!manager->m_geolocationIdMap.contains(geolocation));

static int lastId;

int id = ++lastId;

manager->m_geolocationIdMap.add(geolocation, id);

« no previous file with comments | « third_party/WebKit/Source/web/WebGeolocationController.cpp ('k') | third_party/WebKit/Source/web/WebHeap.cpp » ('j') | no next file with comments »