Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp b/third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp
index ee95063a36d78aa96a4df105848d94611e45af4f..d5331af2ebb29f9f46103292c03f2a11a293927f 100644
--- a/third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp
+++ b/third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp
@@ -130,7 +130,7 @@ String WebFrameSerializerImpl::preActionBeforeSerializeOpenTag(
// Skip the open tag of original META tag which declare charset since we
// have overrided the META which have correct charset declaration after
// serializing open tag of HEAD element.
- ASSERT(element);
+ DCHECK(element);
if (isHTMLMetaElement(element) && toHTMLMetaElement(element)->computeEncoding().isValid()) {
// Found META tag declared charset, we need to skip it when
// serializing DOM.
@@ -449,13 +449,13 @@ WebFrameSerializerImpl::WebFrameSerializerImpl(
, m_xmlEntities(true)
{
// Must specify available webframe.
- ASSERT(frame);
+ DCHECK(frame);
m_specifiedWebLocalFrameImpl = toWebLocalFrameImpl(frame);
// Make sure we have non null client and delegate.
- ASSERT(client);
- ASSERT(delegate);
+ DCHECK(client);
+ DCHECK(delegate);
- ASSERT(m_dataBuffer.isEmpty());
+ DCHECK(m_dataBuffer.isEmpty());
}
bool WebFrameSerializerImpl::serialize()
@@ -487,7 +487,7 @@ bool WebFrameSerializerImpl::serialize()
WebCString(), WebFrameSerializerClient::CurrentFrameIsFinished);
}
- ASSERT(m_dataBuffer.isEmpty());
+ DCHECK(m_dataBuffer.isEmpty());
return didSerialization;
}
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameSerializer.cpp ('k') | third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698