Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp b/third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp
index 853465ab687d65da2ea6ba06b64f34fe02b99ec5..3a903de8a700cf05a062f7b2fae716f1ebe60792 100644
--- a/third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp
+++ b/third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp
@@ -71,7 +71,7 @@ void WebDevToolsFrontendImpl::didClearWindowObject(WebLocalFrameImpl* frame)
if (m_webFrame == frame) {
v8::Isolate* isolate = v8::Isolate::GetCurrent();
ScriptState* scriptState = ScriptState::forMainWorld(m_webFrame->frame());
- ASSERT(scriptState);
+ DCHECK(scriptState);
ScriptState::Scope scope(scriptState);
if (m_devtoolsHost)
@@ -79,7 +79,7 @@ void WebDevToolsFrontendImpl::didClearWindowObject(WebLocalFrameImpl* frame)
m_devtoolsHost = DevToolsHost::create(this, m_webFrame->frame());
v8::Local<v8::Object> global = scriptState->context()->Global();
v8::Local<v8::Value> devtoolsHostObj = toV8(m_devtoolsHost.get(), global, scriptState->isolate());
- ASSERT(!devtoolsHostObj.IsEmpty());
+ DCHECK(!devtoolsHostObj.IsEmpty());
global->Set(v8AtomicString(isolate, "DevToolsHost"), devtoolsHostObj);
}
« no previous file with comments | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp ('k') | third_party/WebKit/Source/web/WebDocument.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698