Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Unified Diff: third_party/WebKit/Source/web/WebBlob.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebBlob.cpp
diff --git a/third_party/WebKit/Source/web/WebBlob.cpp b/third_party/WebKit/Source/web/WebBlob.cpp
index e682c2bced8476a9758f0733fdb17b9ca5714b7b..70fa3b63abf865c4507fc0bd1d95c91306b11e0b 100644
--- a/third_party/WebKit/Source/web/WebBlob.cpp
+++ b/third_party/WebKit/Source/web/WebBlob.cpp
@@ -56,7 +56,7 @@ WebBlob WebBlob::fromV8Value(v8::Local<v8::Value> value)
if (V8Blob::hasInstance(value, v8::Isolate::GetCurrent())) {
v8::Local<v8::Object> object = v8::Local<v8::Object>::Cast(value);
Blob* blob = V8Blob::toImpl(object);
- ASSERT(blob);
+ DCHECK(blob);
return blob;
}
return WebBlob();
@@ -83,7 +83,7 @@ v8::Local<v8::Value> WebBlob::toV8Value(v8::Local<v8::Object> creationContext, v
{
// We no longer use |creationContext| because it's often misused and points
// to a context faked by user script.
- ASSERT(creationContext->CreationContext() == isolate->GetCurrentContext());
+ DCHECK(creationContext->CreationContext() == isolate->GetCurrentContext());
if (!m_private.get())
return v8::Local<v8::Value>();
return toV8(m_private.get(), isolate->GetCurrentContext()->Global(), isolate);
« no previous file with comments | « third_party/WebKit/Source/web/WebArrayBufferConverter.cpp ('k') | third_party/WebKit/Source/web/WebCache.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698