Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Unified Diff: third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp b/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp
index bbe636747538cd1ad157b1f939b9277cdb5143be..a7f489e70ffb4f878f39060434b263e0ae78a0fc 100644
--- a/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp
+++ b/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp
@@ -104,16 +104,16 @@ void SharedWorkerConnector::scriptLoadFailed()
static WebSharedWorkerRepositoryClient::DocumentID getId(void* document)
{
- ASSERT(document);
+ DCHECK(document);
return reinterpret_cast<WebSharedWorkerRepositoryClient::DocumentID>(document);
}
void SharedWorkerRepositoryClientImpl::connect(SharedWorker* worker, PassOwnPtr<WebMessagePortChannel> port, const KURL& url, const String& name, ExceptionState& exceptionState)
{
- ASSERT(m_client);
+ DCHECK(m_client);
// No nested workers (for now) - connect() should only be called from document context.
- ASSERT(worker->getExecutionContext()->isDocument());
+ DCHECK(worker->getExecutionContext()->isDocument());
Document* document = toDocument(worker->getExecutionContext());
// TODO(estark): this is broken, as it only uses the first header
@@ -155,7 +155,7 @@ void SharedWorkerRepositoryClientImpl::connect(SharedWorker* worker, PassOwnPtr<
void SharedWorkerRepositoryClientImpl::documentDetached(Document* document)
{
- ASSERT(m_client);
+ DCHECK(m_client);
m_client->documentDetached(getId(document));
}

Powered by Google App Engine
This is Rietveld 408576698