RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web.

third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 124 matching lines @@
 public:
     void onPrintPage() { m_printedPage = true; }
     bool printedAtLeastOnePage() { return m_printedPage; }
 
 private:
     bool m_printedPage = false;
 };
 
 void TestPlugin::printPage(int pageNumber, WebCanvas* canvas)
 {
-    ASSERT(m_testClient);
+    DCHECK(m_testClient);
     m_testClient->onPrintPage();
 }
 
 WebPluginContainer* getWebPluginContainer(WebView* webView, const WebString& id)
 {
     WebElement element = webView->mainFrame()->document().getElementById(id);
     return element.pluginContainer();
 }
 
 } // namespace
 
 TEST_F(WebPluginContainerTest, WindowToLocalPointTest)
 {
     URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("plugin_container.html"));
     TestPluginWebFrameClient pluginWebFrameClient; // Must outlive webViewHelper.
     FrameTestHelpers::WebViewHelper webViewHelper;
     WebView* webView = webViewHelper.initializeAndLoad(m_baseURL + "plugin_container.html", true, &pluginWebFrameClient);
-    ASSERT(webView);
+    DCHECK(webView);
     webView->settings()->setPluginsEnabled(true);
     webView->resize(WebSize(300, 300));
     webView->updateAllLifecyclePhases();
     runPendingTasks();
 
     WebPluginContainer* pluginContainerOne = getWebPluginContainer(webView, WebString::fromUTF8("translated-plugin"));
-    ASSERT(pluginContainerOne);
+    DCHECK(pluginContainerOne);
     WebPoint point1 = pluginContainerOne->rootFrameToLocalPoint(WebPoint(10, 10));
     ASSERT_EQ(0, point1.x);
     ASSERT_EQ(0, point1.y);
     WebPoint point2 = pluginContainerOne->rootFrameToLocalPoint(WebPoint(100, 100));
     ASSERT_EQ(90, point2.x);
     ASSERT_EQ(90, point2.y);
 
     WebPluginContainer* pluginContainerTwo = getWebPluginContainer(webView, WebString::fromUTF8("rotated-plugin"));
-    ASSERT(pluginContainerTwo);
+    DCHECK(pluginContainerTwo);
     WebPoint point3 = pluginContainerTwo->rootFrameToLocalPoint(WebPoint(0, 10));
     ASSERT_EQ(10, point3.x);
     ASSERT_EQ(0, point3.y);
     WebPoint point4 = pluginContainerTwo->rootFrameToLocalPoint(WebPoint(-10, 10));
     ASSERT_EQ(10, point4.x);
     ASSERT_EQ(10, point4.y);
 }
 
 TEST_F(WebPluginContainerTest, PluginDocumentPluginIsFocused)
 {
     URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("test.pdf"), WebString::fromUTF8("application/pdf"));
 
     TestPluginWebFrameClient pluginWebFrameClient; // Must outlive webViewHelper.
     FrameTestHelpers::WebViewHelper webViewHelper;
     WebView* webView = webViewHelper.initializeAndLoad(m_baseURL + "test.pdf", true, &pluginWebFrameClient);
-    ASSERT(webView);
+    DCHECK(webView);
     webView->updateAllLifecyclePhases();
 
     WebDocument document = webView->mainFrame()->document();
     EXPECT_TRUE(document.isPluginDocument());
     WebPluginContainer* pluginContainer = getWebPluginContainer(webView, "plugin");
     EXPECT_EQ(document.focusedElement(), pluginContainer->element());
 }
 
 TEST_F(WebPluginContainerTest, IFramePluginDocumentNotFocused)
 {
     URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("test.pdf"), WebString::fromUTF8("application/pdf"));
     URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("iframe_pdf.html"), WebString::fromUTF8("text/html"));
 
     TestPluginWebFrameClient pluginWebFrameClient; // Must outlive webViewHelper.
     FrameTestHelpers::WebViewHelper webViewHelper;
     WebView* webView = webViewHelper.initializeAndLoad(m_baseURL + "iframe_pdf.html", true, &pluginWebFrameClient);
-    ASSERT(webView);
+    DCHECK(webView);
     webView->updateAllLifecyclePhases();
 
     WebDocument document = webView->mainFrame()->document();
     WebFrame* iframe = webView->mainFrame()->firstChild();
     EXPECT_TRUE(iframe->document().isPluginDocument());
     WebPluginContainer* pluginContainer = iframe->document().getElementById("plugin").pluginContainer();
     EXPECT_NE(document.focusedElement(), pluginContainer->element());
     EXPECT_NE(iframe->document().focusedElement(), pluginContainer->element());
 }
 
 TEST_F(WebPluginContainerTest, PrintOnePage)
 {
     URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("test.pdf"), WebString::fromUTF8("application/pdf"));
 
     TestPluginWebFrameClient pluginWebFrameClient; // Must outlive webViewHelper.
     FrameTestHelpers::WebViewHelper webViewHelper;
     WebView* webView = webViewHelper.initializeAndLoad(m_baseURL + "test.pdf", true, &pluginWebFrameClient);
-    ASSERT(webView);
+    DCHECK(webView);
     webView->updateAllLifecyclePhases();
     runPendingTasks();
     WebFrame* frame = webView->mainFrame();
 
     WebPrintParams printParams;
     printParams.printContentArea.width = 500;
     printParams.printContentArea.height = 500;
 
     frame->printBegin(printParams);
     SkPictureRecorder recorder;
     frame->printPage(0, recorder.beginRecording(IntRect()));
     frame->printEnd();
-    ASSERT(pluginWebFrameClient.printedAtLeastOnePage());
+    DCHECK(pluginWebFrameClient.printedAtLeastOnePage());
 }
 
 TEST_F(WebPluginContainerTest, PrintAllPages)
 {
     URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("test.pdf"), WebString::fromUTF8("application/pdf"));
 
     TestPluginWebFrameClient pluginWebFrameClient; // Must outlive webViewHelper.
     FrameTestHelpers::WebViewHelper webViewHelper;
     WebView* webView = webViewHelper.initializeAndLoad(m_baseURL + "test.pdf", true, &pluginWebFrameClient);
-    ASSERT(webView);
+    DCHECK(webView);
     webView->updateAllLifecyclePhases();
     runPendingTasks();
     WebFrame* frame = webView->mainFrame();
 
     WebPrintParams printParams;
     printParams.printContentArea.width = 500;
     printParams.printContentArea.height = 500;
 
     frame->printBegin(printParams);
     SkPictureRecorder recorder;
     frame->printPagesWithBoundaries(recorder.beginRecording(IntRect()), WebSize());
     frame->printEnd();
-    ASSERT(pluginWebFrameClient.printedAtLeastOnePage());
+    DCHECK(pluginWebFrameClient.printedAtLeastOnePage());
 }
 
 TEST_F(WebPluginContainerTest, LocalToWindowPointTest)
 {
     URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("plugin_container.html"));
     TestPluginWebFrameClient pluginWebFrameClient; // Must outlive webViewHelper.
     FrameTestHelpers::WebViewHelper webViewHelper;
     WebView* webView = webViewHelper.initializeAndLoad(m_baseURL + "plugin_container.html", true, &pluginWebFrameClient);
-    ASSERT(webView);
+    DCHECK(webView);
     webView->settings()->setPluginsEnabled(true);
     webView->resize(WebSize(300, 300));
     webView->updateAllLifecyclePhases();
     runPendingTasks();
 
     WebPluginContainer* pluginContainerOne = getWebPluginContainer(webView, WebString::fromUTF8("translated-plugin"));
-    ASSERT(pluginContainerOne);
+    DCHECK(pluginContainerOne);
     WebPoint point1 = pluginContainerOne->localToRootFramePoint(WebPoint(0, 0));
     ASSERT_EQ(10, point1.x);
     ASSERT_EQ(10, point1.y);
     WebPoint point2 = pluginContainerOne->localToRootFramePoint(WebPoint(90, 90));
     ASSERT_EQ(100, point2.x);
     ASSERT_EQ(100, point2.y);
 
     WebPluginContainer* pluginContainerTwo = getWebPluginContainer(webView, WebString::fromUTF8("rotated-plugin"));
-    ASSERT(pluginContainerTwo);
+    DCHECK(pluginContainerTwo);
     WebPoint point3 = pluginContainerTwo->localToRootFramePoint(WebPoint(10, 0));
     ASSERT_EQ(0, point3.x);
     ASSERT_EQ(10, point3.y);
     WebPoint point4 = pluginContainerTwo->localToRootFramePoint(WebPoint(10, 10));
     ASSERT_EQ(-10, point4.x);
     ASSERT_EQ(10, point4.y);
 }
 
 // Verifies executing the command 'Copy' results in copying to the clipboard.
 TEST_F(WebPluginContainerTest, Copy)
 {
     URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("plugin_container.html"));
     TestPluginWebFrameClient pluginWebFrameClient; // Must outlive webViewHelper.
     FrameTestHelpers::WebViewHelper webViewHelper;
     WebView* webView = webViewHelper.initializeAndLoad(m_baseURL + "plugin_container.html", true, &pluginWebFrameClient);
-    ASSERT(webView);
+    DCHECK(webView);
     webView->settings()->setPluginsEnabled(true);
     webView->resize(WebSize(300, 300));
     webView->updateAllLifecyclePhases();
     runPendingTasks();
 
     WebElement pluginContainerOneElement = webView->mainFrame()->document().getElementById(WebString::fromUTF8("translated-plugin"));
     EXPECT_TRUE(webView->mainFrame()->executeCommand("Copy",  pluginContainerOneElement));
     EXPECT_EQ(WebString("x"), Platform::current()->clipboard()->readPlainText(WebClipboard::Buffer()));
 }
 
 // Verifies |Ctrl-C| and |Ctrl-Insert| keyboard events, results in copying to
 // the clipboard.
 TEST_F(WebPluginContainerTest, CopyInsertKeyboardEventsTest)
 {
     URLTestHelpers::registerMockedURLFromBaseURL(
         WebString::fromUTF8(m_baseURL.c_str()),
         WebString::fromUTF8("plugin_container.html"));
     TestPluginWebFrameClient pluginWebFrameClient; // Must outlive webViewHelper.
     FrameTestHelpers::WebViewHelper webViewHelper;
     WebView* webView = webViewHelper.initializeAndLoad(m_baseURL + "plugin_container.html", true, &pluginWebFrameClient);
-    ASSERT(webView);
+    DCHECK(webView);
     webView->settings()->setPluginsEnabled(true);
     webView->resize(WebSize(300, 300));
     webView->updateAllLifecyclePhases();
     runPendingTasks();
 
     WebElement pluginContainerOneElement = webView->mainFrame()->document().getElementById(WebString::fromUTF8("translated-plugin"));
     PlatformEvent::Modifiers modifierKey = static_cast<PlatformEvent::Modifiers>(PlatformEvent::CtrlKey | PlatformEvent::NumLockOn | PlatformEvent::IsLeft);
 #if OS(MACOSX)
     modifierKey = static_cast<PlatformEvent::Modifiers>(PlatformEvent::MetaKey | PlatformEvent::NumLockOn | PlatformEvent::IsLeft);
 #endif
@@ skipping 33 matching lines @@
 };
 
 TEST_F(WebPluginContainerTest, GestureLongPressReachesPlugin)
 {
     URLTestHelpers::registerMockedURLFromBaseURL(
         WebString::fromUTF8(m_baseURL.c_str()),
         WebString::fromUTF8("plugin_container.html"));
     CustomPluginWebFrameClient<EventTestPlugin> pluginWebFrameClient; // Must outlive webViewHelper.
     FrameTestHelpers::WebViewHelper webViewHelper;
     WebView* webView = webViewHelper.initializeAndLoad(m_baseURL + "plugin_container.html", true, &pluginWebFrameClient);
-    ASSERT(webView);
+    DCHECK(webView);
     webView->settings()->setPluginsEnabled(true);
     webView->resize(WebSize(300, 300));
     webView->updateAllLifecyclePhases();
     runPendingTasks();
 
     WebElement pluginContainerOneElement = webView->mainFrame()->document().getElementById(WebString::fromUTF8("translated-plugin"));
     WebPlugin* plugin = static_cast<WebPluginContainerImpl*>(pluginContainerOneElement.pluginContainer())->plugin();
     EventTestPlugin* testPlugin = static_cast<EventTestPlugin*>(plugin);
 
     WebGestureEvent event;
@@ skipping 21 matching lines @@
     EXPECT_EQ(WebInputEvent::GestureLongPress, testPlugin->getLastInputEventType());
 }
 
 // Verify that isRectTopmost returns false when the document is detached.
 TEST_F(WebPluginContainerTest, IsRectTopmostTest)
 {
     URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("plugin_container.html"));
     TestPluginWebFrameClient pluginWebFrameClient; // Must outlive webViewHelper.
     FrameTestHelpers::WebViewHelper webViewHelper;
     WebView* webView = webViewHelper.initializeAndLoad(m_baseURL + "plugin_container.html", true, &pluginWebFrameClient);
-    ASSERT(webView);
+    DCHECK(webView);
     webView->settings()->setPluginsEnabled(true);
     webView->resize(WebSize(300, 300));
     webView->updateAllLifecyclePhases();
     runPendingTasks();
 
     RawPtr<WebPluginContainerImpl> pluginContainerImpl =
         toWebPluginContainerImpl(getWebPluginContainer(webView, WebString::fromUTF8("translated-plugin")));
     pluginContainerImpl->setFrameRect(IntRect(0, 0, 300, 300));
 
     WebRect rect = pluginContainerImpl->element().boundsInViewport();
@@ skipping 15 matching lines @@
     } while (false)
 
 TEST_F(WebPluginContainerTest, ClippedRectsForIframedElement)
 {
     URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("plugin_container.html"));
     URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("plugin_containing_page.html"));
 
     TestPluginWebFrameClient pluginWebFrameClient; // Must outlive webViewHelper.
     FrameTestHelpers::WebViewHelper webViewHelper;
     WebView* webView = webViewHelper.initializeAndLoad(m_baseURL + "plugin_containing_page.html", true, &pluginWebFrameClient);
-    ASSERT(webView);
+    DCHECK(webView);
     webView->settings()->setPluginsEnabled(true);
     webView->resize(WebSize(300, 300));
     webView->updateAllLifecyclePhases();
     runPendingTasks();
 
     WebElement pluginElement = webView->mainFrame()->firstChild()->document().getElementById("translated-plugin");
     RawPtr<WebPluginContainerImpl> pluginContainerImpl = toWebPluginContainerImpl(pluginElement.pluginContainer());
 
-    ASSERT(pluginContainerImpl.get());
+    DCHECK(pluginContainerImpl.get());
     pluginContainerImpl->setFrameRect(IntRect(0, 0, 300, 300));
 
     IntRect windowRect, clipRect, unobscuredRect;
     Vector<IntRect> cutOutRects;
     calculateGeometry(pluginContainerImpl.get(), windowRect, clipRect, unobscuredRect, cutOutRects);
     EXPECT_RECT_EQ(IntRect(10, 210, 300, 300), windowRect);
     EXPECT_RECT_EQ(IntRect(0, 0, 240, 90), clipRect);
     EXPECT_RECT_EQ(IntRect(0, 0, 240, 160), unobscuredRect);
 
     // Cause the plugin's frame to be detached.
     webViewHelper.reset();
 }
 
 TEST_F(WebPluginContainerTest, ClippedRectsForSubpixelPositionedPlugin)
 {
     URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("plugin_container.html"));
 
     TestPluginWebFrameClient pluginWebFrameClient; // Must outlive webViewHelper.
     FrameTestHelpers::WebViewHelper webViewHelper;
     WebView* webView = webViewHelper.initializeAndLoad(m_baseURL + "plugin_container.html", true, &pluginWebFrameClient);
-    ASSERT(webView);
+    DCHECK(webView);
     webView->settings()->setPluginsEnabled(true);
     webView->resize(WebSize(300, 300));
     webView->updateAllLifecyclePhases();
     runPendingTasks();
 
     WebElement pluginElement = webView->mainFrame()->document().getElementById("subpixel-positioned-plugin");
     RawPtr<WebPluginContainerImpl> pluginContainerImpl = toWebPluginContainerImpl(pluginElement.pluginContainer());
 
-    ASSERT(pluginContainerImpl.get());
+    DCHECK(pluginContainerImpl.get());
 
     IntRect windowRect, clipRect, unobscuredRect;
     Vector<IntRect> cutOutRects;
 
     calculateGeometry(pluginContainerImpl.get(), windowRect, clipRect, unobscuredRect, cutOutRects);
     // TODO(chrishtr): these values should not be -1, they should be 0. They are -1 because WebPluginContainerImpl currently uses an IntRect for
     // frameRect() to determine the position of the plugin, which results in a loss of precision if it is actually subpixel positioned.
     EXPECT_RECT_EQ(IntRect(0, 0, 40, 40), windowRect);
     EXPECT_RECT_EQ(IntRect(-1, -1, 41, 41), clipRect);
     EXPECT_RECT_EQ(IntRect(-1, -1, 41, 41), unobscuredRect);
@@ skipping 22 matching lines @@
             // In destroy, isRectTopmost is no longer valid.
             EXPECT_FALSE(container()->isRectTopmost(topmostRect));
             FakeWebPlugin::destroy();
         }
     };
 
     URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("plugin_container.html"));
     CustomPluginWebFrameClient<TopmostPlugin> pluginWebFrameClient; // Must outlive webViewHelper.
     FrameTestHelpers::WebViewHelper webViewHelper;
     WebView* webView = webViewHelper.initializeAndLoad(m_baseURL + "plugin_container.html", true, &pluginWebFrameClient);
-    ASSERT(webView);
+    DCHECK(webView);
     webView->settings()->setPluginsEnabled(true);
     webView->resize(WebSize(300, 300));
     webView->updateAllLifecyclePhases();
     runPendingTasks();
 
     RawPtr<WebPluginContainerImpl> pluginContainerImpl =
         toWebPluginContainerImpl(getWebPluginContainer(webView, WebString::fromUTF8("translated-plugin")));
     pluginContainerImpl->setFrameRect(IntRect(0, 0, 300, 300));
 
     EXPECT_TRUE(pluginContainerImpl->isRectTopmost(topmostRect));
@@ skipping 81 matching lines @@
 }
 
 TEST_F(WebPluginContainerTest, NeedsWheelEvents)
 {
     URLTestHelpers::registerMockedURLFromBaseURL(
         WebString::fromUTF8(m_baseURL.c_str()),
         WebString::fromUTF8("plugin_container.html"));
     TestPluginWebFrameClient pluginWebFrameClient; // Must outlive webViewHelper
     FrameTestHelpers::WebViewHelper webViewHelper;
     WebViewImpl* webView = webViewHelper.initializeAndLoad(m_baseURL + "plugin_container.html", true, &pluginWebFrameClient);
-    ASSERT(webView);
+    DCHECK(webView);
     webView->settings()->setPluginsEnabled(true);
     webView->resize(WebSize(300, 300));
     webView->updateAllLifecyclePhases();
     runPendingTasks();
 
     WebElement pluginContainerOneElement = webView->mainFrame()->document().getElementById(WebString::fromUTF8("translated-plugin"));
     pluginContainerOneElement.pluginContainer()->setWantsWheelEvents(true);
 
     runPendingTasks();
     EXPECT_TRUE(webView->page()->frameHost().eventHandlerRegistry().hasEventHandlers(EventHandlerRegistry::WheelEventBlocking));
 }
 
 } // namespace blink