Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1465)

Side by Side Diff: third_party/WebKit/Source/web/WebInputEventConversion.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
349 m_modifiers = e.modifiers; 349 m_modifiers = e.modifiers;
350 m_timestamp = e.timeStampSeconds; 350 m_timestamp = e.timeStampSeconds;
351 m_windowsVirtualKeyCode = e.windowsKeyCode; 351 m_windowsVirtualKeyCode = e.windowsKeyCode;
352 } 352 }
353 353
354 void PlatformKeyboardEventBuilder::setKeyType(EventType type) 354 void PlatformKeyboardEventBuilder::setKeyType(EventType type)
355 { 355 {
356 // According to the behavior of Webkit in Windows platform, 356 // According to the behavior of Webkit in Windows platform,
357 // we need to convert KeyDown to RawKeydown and Char events 357 // we need to convert KeyDown to RawKeydown and Char events
358 // See WebKit/WebKit/Win/WebView.cpp 358 // See WebKit/WebKit/Win/WebView.cpp
359 ASSERT(m_type == KeyDown); 359 DCHECK(m_type == KeyDown);
360 ASSERT(type == RawKeyDown || type == Char); 360 DCHECK(type == RawKeyDown || type == Char);
361 m_type = type; 361 m_type = type;
362 362
363 if (type == RawKeyDown) { 363 if (type == RawKeyDown) {
364 m_text = String(); 364 m_text = String();
365 m_unmodifiedText = String(); 365 m_unmodifiedText = String();
366 } else { 366 } else {
367 m_keyIdentifier = String(); 367 m_keyIdentifier = String();
368 m_windowsVirtualKeyCode = 0; 368 m_windowsVirtualKeyCode = 0;
369 } 369 }
370 } 370 }
(...skipping 412 matching lines...) Expand 10 before | Expand all | Expand 10 after
783 break; 783 break;
784 case GestureSourceTouchscreen: 784 case GestureSourceTouchscreen:
785 sourceDevice = WebGestureDeviceTouchscreen; 785 sourceDevice = WebGestureDeviceTouchscreen;
786 break; 786 break;
787 case GestureSourceUninitialized: 787 case GestureSourceUninitialized:
788 ASSERT_NOT_REACHED(); 788 ASSERT_NOT_REACHED();
789 } 789 }
790 } 790 }
791 791
792 } // namespace blink 792 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebImageDecoder.cpp ('k') | third_party/WebKit/Source/web/WebKit.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698