Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Side by Side Diff: third_party/WebKit/Source/web/DateTimeChooserImpl.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 45
46 namespace blink { 46 namespace blink {
47 47
48 DateTimeChooserImpl::DateTimeChooserImpl(ChromeClientImpl* chromeClient, DateTim eChooserClient* client, const DateTimeChooserParameters& parameters) 48 DateTimeChooserImpl::DateTimeChooserImpl(ChromeClientImpl* chromeClient, DateTim eChooserClient* client, const DateTimeChooserParameters& parameters)
49 : m_chromeClient(chromeClient) 49 : m_chromeClient(chromeClient)
50 , m_client(client) 50 , m_client(client)
51 , m_popup(0) 51 , m_popup(0)
52 , m_parameters(parameters) 52 , m_parameters(parameters)
53 , m_locale(Locale::create(parameters.locale)) 53 , m_locale(Locale::create(parameters.locale))
54 { 54 {
55 ASSERT(m_chromeClient); 55 DCHECK(m_chromeClient);
56 ASSERT(m_client); 56 DCHECK(m_client);
57 m_popup = m_chromeClient->openPagePopup(this); 57 m_popup = m_chromeClient->openPagePopup(this);
58 } 58 }
59 59
60 RawPtr<DateTimeChooserImpl> DateTimeChooserImpl::create(ChromeClientImpl* chrome Client, DateTimeChooserClient* client, const DateTimeChooserParameters& paramete rs) 60 RawPtr<DateTimeChooserImpl> DateTimeChooserImpl::create(ChromeClientImpl* chrome Client, DateTimeChooserClient* client, const DateTimeChooserParameters& paramete rs)
61 { 61 {
62 return new DateTimeChooserImpl(chromeClient, client, parameters); 62 return new DateTimeChooserImpl(chromeClient, client, parameters);
63 } 63 }
64 64
65 DateTimeChooserImpl::~DateTimeChooserImpl() 65 DateTimeChooserImpl::~DateTimeChooserImpl()
66 { 66 {
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 m_client->didChooseValue(value); 198 m_client->didChooseValue(value);
199 } 199 }
200 200
201 void DateTimeChooserImpl::closePopup() 201 void DateTimeChooserImpl::closePopup()
202 { 202 {
203 endChooser(); 203 endChooser();
204 } 204 }
205 205
206 void DateTimeChooserImpl::didClosePopup() 206 void DateTimeChooserImpl::didClosePopup()
207 { 207 {
208 ASSERT(m_client); 208 DCHECK(m_client);
209 m_popup = nullptr; 209 m_popup = nullptr;
210 m_client->didEndChooser(); 210 m_client->didEndChooser();
211 } 211 }
212 212
213 } // namespace blink 213 } // namespace blink
214 214
215 #endif // ENABLE(INPUT_MULTIPLE_FIELDS_UI) 215 #endif // ENABLE(INPUT_MULTIPLE_FIELDS_UI)
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/DatabaseClientImpl.cpp ('k') | third_party/WebKit/Source/web/DragClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698