Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1839643003: Fixes for AST summary generation when variables are missing. (Closed)

Created:
4 years, 8 months ago by scheglov
Modified:
4 years, 8 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes for AST summary generation when variables are missing. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/7f145a0ad9c422fd9f09e7b4f2aad025479b7ef9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 2 chunks +8 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/in_summary_source_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 8 months ago (2016-03-28 20:49:28 UTC) #1
Paul Berry
lgtm
4 years, 8 months ago (2016-03-28 20:50:21 UTC) #2
scheglov
4 years, 8 months ago (2016-03-28 20:51:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7f145a0ad9c422fd9f09e7b4f2aad025479b7ef9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698