Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1839633003:
SkPDF: PDFDevice::ContentEntry now implemented with SinglyLinkedList (Closed)
|
Created:
4 years, 8 months ago by hal.canary Modified:
4 years, 8 months ago Reviewers:
bungeman-skia CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionSkPDF: PDFDevice::ContentEntry now implemented with SinglyLinkedList
add SkSinglyLinkedList<T> class
no change in SkPDF output.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1839633003
Committed: https://skia.googlesource.com/skia/+/2be7e01382ee9c036de9c09585677dfd25d70253
Patch Set 1 : 2016-03-28 (Monday) 12:15:25 EDT #
Total comments: 6
Patch Set 2 : 2016-03-28 (Monday) 12:28:08 EDT #Patch Set 3 : 2016-03-28 (Monday) 12:54:04 EDT #
Total comments: 2
Patch Set 4 : 2016-03-28 (Monday) 13:12:45 EDT #
Messages
Total messages: 28 (14 generated)
Description was changed from ========== SkPDF: PDFDevice::ContentEntry now implemented with SinglyLinkedList add SkSinglyLinkedList<T> class ========== to ========== SkPDF: PDFDevice::ContentEntry now implemented with SinglyLinkedList add SkSinglyLinkedList<T> class GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Patchset #1 (id:1) has been deleted
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839633003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839633003/20001
halcanary@google.com changed reviewers: + bungeman@google.com
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
https://codereview.chromium.org/1839633003/diff/20001/gyp/pdf.gypi File gyp/pdf.gypi (right): https://codereview.chromium.org/1839633003/diff/20001/gyp/pdf.gypi#newcode48 gyp/pdf.gypi:48: '<(skia_src_path)/pdf/src/pdf/SkSinglyLinkedList.h', Don't need pdf/src. https://codereview.chromium.org/1839633003/diff/20001/src/pdf/SkSinglyLinkedL... File src/pdf/SkSinglyLinkedList.h (right): https://codereview.chromium.org/1839633003/diff/20001/src/pdf/SkSinglyLinkedL... src/pdf/SkSinglyLinkedList.h:31: new (this) SkSinglyLinkedList<T>(); Instead of doing it this way, put the clearing code into here (reset) and have the destructor call reset. https://codereview.chromium.org/1839633003/diff/20001/src/pdf/SkSinglyLinkedL... src/pdf/SkSinglyLinkedList.h:35: int count() { Is it expected that count will be O(n)?
https://codereview.chromium.org/1839633003/diff/20001/gyp/pdf.gypi File gyp/pdf.gypi (right): https://codereview.chromium.org/1839633003/diff/20001/gyp/pdf.gypi#newcode48 gyp/pdf.gypi:48: '<(skia_src_path)/pdf/src/pdf/SkSinglyLinkedList.h', On 2016/03/28 16:28:17, bungeman1 wrote: > Don't need pdf/src. already fixed https://codereview.chromium.org/1839633003/diff/20001/src/pdf/SkSinglyLinkedL... File src/pdf/SkSinglyLinkedList.h (right): https://codereview.chromium.org/1839633003/diff/20001/src/pdf/SkSinglyLinkedL... src/pdf/SkSinglyLinkedList.h:35: int count() { On 2016/03/28 16:28:17, bungeman1 wrote: > Is it expected that count will be O(n)? only used in asserts.
Description was changed from ========== SkPDF: PDFDevice::ContentEntry now implemented with SinglyLinkedList add SkSinglyLinkedList<T> class GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== SkPDF: PDFDevice::ContentEntry now implemented with SinglyLinkedList add SkSinglyLinkedList<T> class More local testing first: COMMIT=false GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839633003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839633003/60001
lgtm with one nit: https://codereview.chromium.org/1839633003/diff/60001/src/pdf/SkPDFDevice.cpp File src/pdf/SkPDFDevice.cpp (right): https://codereview.chromium.org/1839633003/diff/60001/src/pdf/SkPDFDevice.cpp... src/pdf/SkPDFDevice.cpp:1395: // void SkPDFDevice::copyContentEntriesToData(ContentEntry* entry, Why commented out? Just remove?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/1839633003/diff/60001/src/pdf/SkPDFDevice.cpp File src/pdf/SkPDFDevice.cpp (right): https://codereview.chromium.org/1839633003/diff/60001/src/pdf/SkPDFDevice.cpp... src/pdf/SkPDFDevice.cpp:1395: // void SkPDFDevice::copyContentEntriesToData(ContentEntry* entry, On 2016/03/28 16:59:22, bungeman1 wrote: > Why commented out? Just remove? Done.
https://codereview.chromium.org/1839633003/diff/20001/src/pdf/SkSinglyLinkedL... File src/pdf/SkSinglyLinkedList.h (right): https://codereview.chromium.org/1839633003/diff/20001/src/pdf/SkSinglyLinkedL... src/pdf/SkSinglyLinkedList.h:31: new (this) SkSinglyLinkedList<T>(); On 2016/03/28 16:28:18, bungeman1 wrote: > Instead of doing it this way, put the clearing code into here (reset) and have > the destructor call reset. Done.
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839633003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839633003/80001
Description was changed from ========== SkPDF: PDFDevice::ContentEntry now implemented with SinglyLinkedList add SkSinglyLinkedList<T> class More local testing first: COMMIT=false GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== SkPDF: PDFDevice::ContentEntry now implemented with SinglyLinkedList add SkSinglyLinkedList<T> class no change in SkPDF output. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by halcanary@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com Link to the patchset: https://codereview.chromium.org/1839633003/#ps80001 (title: "2016-03-28 (Monday) 13:12:45 EDT")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839633003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839633003/80001
Message was sent while issue was closed.
Description was changed from ========== SkPDF: PDFDevice::ContentEntry now implemented with SinglyLinkedList add SkSinglyLinkedList<T> class no change in SkPDF output. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== SkPDF: PDFDevice::ContentEntry now implemented with SinglyLinkedList add SkSinglyLinkedList<T> class no change in SkPDF output. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/2be7e01382ee9c036de9c09585677dfd25d70253 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as https://skia.googlesource.com/skia/+/2be7e01382ee9c036de9c09585677dfd25d70253 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
