Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1839583003: [Autofill] Log the number of stored local credit cards (Closed)

Created:
4 years, 9 months ago by Mathieu
Modified:
4 years, 8 months ago
Reviewers:
Ilya Sherman
CC:
asvitkine+watch_chromium.org, bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, rouslan+autofill_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Log the number of stored local credit cards BUG=598213 TEST=AutofillMetricsTest Committed: https://crrev.com/96365cb91757d4b449d265f4b09493fa9c7a4245 Cr-Commit-Position: refs/heads/master@{#383641}

Patch Set 1 #

Total comments: 3

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -2 lines) Patch
M components/autofill/core/browser/autofill_metrics.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics_unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.h View 2 chunks +9 lines, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 3 chunks +10 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Mathieu
Hi Ilya, please have a look!
4 years, 9 months ago (2016-03-27 18:15:02 UTC) #2
Ilya Sherman
LGTM % nits: https://codereview.chromium.org/1839583003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1839583003/diff/1/tools/metrics/histograms/histograms.xml#newcode2751 tools/metrics/histograms/histograms.xml:2751: + The number of local Credit ...
4 years, 8 months ago (2016-03-28 23:33:12 UTC) #3
Mathieu
Thanks, will submit https://codereview.chromium.org/1839583003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1839583003/diff/1/tools/metrics/histograms/histograms.xml#newcode2751 tools/metrics/histograms/histograms.xml:2751: + The number of local Credit ...
4 years, 8 months ago (2016-03-28 23:42:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839583003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839583003/20001
4 years, 8 months ago (2016-03-28 23:43:03 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 01:00:20 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 01:01:58 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/96365cb91757d4b449d265f4b09493fa9c7a4245
Cr-Commit-Position: refs/heads/master@{#383641}

Powered by Google App Engine
This is Rietveld 408576698