tools/clang/rewrite_to_chrome_style/tests/variables-original.cc - Issue 1839573002: rewrite_to_chrome_style: making globals great again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/variables-original.cc

Issue 1839573002: rewrite_to_chrome_style: making globals great again. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/variables-expected.cc ('k') | tools/clang/rewrite_to_chrome_style/tests/wtf-expected.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/rewrite_to_chrome_style/tests/variables-original.cc

diff --git a/tools/clang/rewrite_to_chrome_style/tests/variables-original.cc b/tools/clang/rewrite_to_chrome_style/tests/variables-original.cc

index 84ced2c76aaae559f87856e502444a3d716ee442..de4223eb7bfdc1066879c5174d249ff3ee2a6a0f 100644

--- a/tools/clang/rewrite_to_chrome_style/tests/variables-original.cc

+++ b/tools/clang/rewrite_to_chrome_style/tests/variables-original.cc

@@ -8,8 +8,10 @@ namespace blink {

int frameCount = 0;

// Make sure that underscore-insertion doesn't get too confused by acronyms.

static int variableMentioningHTTPAndHTTPS = 1;

+// g_ prefix, but doesn't follow Google style.

+int g_withBlinkNaming;

// Already Google style, should not change.

-int already_google_style_;

+int g_already_google_style_;

// Function parameters

int function(int interestingNumber) {