Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 1839533002: Revert of Make GraphicsLayer the DisplayItemClient for scrollbars composited via PaintLayerCompositor. (Closed)

Created:
4 years, 9 months ago by nednguyen
Modified:
4 years, 9 months ago
Reviewers:
chrishtr, wkorman
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), jbroman, jchaffraix+rendering, Justin Novosad, kinuko+watch, leviw+renderwatch, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make GraphicsLayer the DisplayItemClient for scrollbars composited via PaintLayerCompositor. (patchset #6 id:100001 of https://codereview.chromium.org/1825193002/ ) Reason for revert: Speculative revert: this may cause crash for rasterize_and_record_micro benchmark. BUG=597391 Original issue's description: > Make GraphicsLayer the DisplayItemClient for scrollbars composited via PaintLayerCompositor. > > Currently, the DisplayItemClient is LayoutScrollbarPart. This has two > problems: the mapping between the LayoutScrollbarPart and its backing > is hard to reverse-engineer given the way the scrollbar code is set > up (LayoutScrollbarPart vs Scrollbar vs ScrollableArea), and the > fact that LayoutScrollbarPart can be painted in both non-composited > and composited modes. This distinction is important for computation > of correct visual rects. > > This can be cleaned up by replaying the painted scrollbar content > with the GraphicsLayer backing as the DisplayItemClient, which > has the correct visualRect() (i.e. bounds of GraphicsLayer). > > BUG=529938 > > Committed: https://crrev.com/8460ef8fc6125185abc1486eb61b0ca7fc9298ad > Cr-Commit-Position: refs/heads/master@{#382778} TBR=chrishtr@chromium.org,wkorman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=529938 Committed: https://crrev.com/043ab27b4a422d665580b12b588cba2d47afc387 Cr-Commit-Position: refs/heads/master@{#383451}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -44 lines) Patch
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 4 chunks +12 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (2 generated)
nednguyen
4 years, 9 months ago (2016-03-26 04:13:52 UTC) #1
Created Revert of Make GraphicsLayer the DisplayItemClient for scrollbars
composited via PaintLayerCompositor.

Powered by Google App Engine
This is Rietveld 408576698