Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183953005: Rename components's Encryptor to OSEncrypt. (Closed)

Created:
6 years, 9 months ago by tfarina
Modified:
6 years, 9 months ago
Reviewers:
bcwhite, Lei Zhang, Jói
CC:
chromium-reviews, tim+watch_chromium.org, cbentzel+watch_chromium.org, benquan, haitaol+watch_chromium.org, browser-components-watch_chromium.org, Dane Wallinga, dyu1, tfarina, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Rename components's Encryptor to OSEncrypt. To avoid confusion with the Encryptor class that exists under crypto/. BUG=341293 TEST=None R=joi@chromium.org,bcwhite@chromium.org TBR=thestig Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254177

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : KeychainPassword #

Patch Set 4 : similarity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -926 lines) Patch
M chrome/browser/net/cookie_store_util.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service_unittest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/signin/local_auth.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/signin/local_auth_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/mutable_profile_oauth2_token_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_ie_toolbar_import_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_test_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/components_tests.gyp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M components/encryptor.gypi View 1 2 1 chunk +9 lines, -9 lines 0 comments Download
D components/encryptor/encryptor.h View 1 chunk +0 lines, -51 lines 0 comments Download
D components/encryptor/encryptor_mac.mm View 1 chunk +0 lines, -155 lines 0 comments Download
M components/encryptor/encryptor_password_mac.h View 1 2 1 chunk +0 lines, -35 lines 0 comments Download
D components/encryptor/encryptor_password_mac.mm View 1 2 1 chunk +0 lines, -79 lines 0 comments Download
D components/encryptor/encryptor_password_mac_unittest.cc View 1 2 1 chunk +0 lines, -79 lines 0 comments Download
D components/encryptor/encryptor_posix.cc View 1 chunk +0 lines, -139 lines 0 comments Download
M components/encryptor/encryptor_switches.h View 1 chunk +1 line, -1 line 0 comments Download
D components/encryptor/encryptor_unittest.cc View 1 chunk +0 lines, -143 lines 0 comments Download
D components/encryptor/encryptor_win.cc View 1 chunk +0 lines, -65 lines 0 comments Download
A + components/encryptor/keychain_password_mac.h View 1 2 1 chunk +11 lines, -10 lines 0 comments Download
A + components/encryptor/keychain_password_mac.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + components/encryptor/keychain_password_mac_unittest.mm View 1 2 2 chunks +19 lines, -18 lines 0 comments Download
A + components/encryptor/os_crypt.h View 1 2 3 2 chunks +16 lines, -19 lines 0 comments Download
A + components/encryptor/os_crypt_mac.mm View 1 2 7 chunks +13 lines, -13 lines 0 comments Download
A + components/encryptor/os_crypt_posix.cc View 4 chunks +9 lines, -9 lines 0 comments Download
A + components/encryptor/os_crypt_unittest.cc View 3 chunks +38 lines, -37 lines 0 comments Download
A + components/encryptor/os_crypt_win.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M components/password_manager/core/browser/login_database_win.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M components/signin/core/webdata/token_service_table.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/sync_driver/system_encryptor.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/sync_driver/system_encryptor_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M google_apis/gcm/engine/mcs_client_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gcm/gcm_client_impl_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
tfarina
6 years, 9 months ago (2014-02-28 02:37:37 UTC) #1
Jói
https://codereview.chromium.org/183953005/diff/20001/components/encryptor/encryptor_password_mac.h File components/encryptor/encryptor_password_mac.h (right): https://codereview.chromium.org/183953005/diff/20001/components/encryptor/encryptor_password_mac.h#newcode16 components/encryptor/encryptor_password_mac.h:16: class EncryptorPassword { Shouldn't this (and similar classes) also ...
6 years, 9 months ago (2014-02-28 13:43:38 UTC) #2
tfarina
https://codereview.chromium.org/183953005/diff/20001/components/encryptor/encryptor_password_mac.h File components/encryptor/encryptor_password_mac.h (right): https://codereview.chromium.org/183953005/diff/20001/components/encryptor/encryptor_password_mac.h#newcode16 components/encryptor/encryptor_password_mac.h:16: class EncryptorPassword { On 2014/02/28 13:43:39, Jói wrote: > ...
6 years, 9 months ago (2014-02-28 14:26:56 UTC) #3
tfarina
https://codereview.chromium.org/183953005/diff/20001/components/encryptor/os_crypt.h File components/encryptor/os_crypt.h (right): https://codereview.chromium.org/183953005/diff/20001/components/encryptor/os_crypt.h#newcode5 components/encryptor/os_crypt.h:5: #ifndef COMPONENTS_ENCRYPTOR_OS_CRYPT_H_ On 2014/02/28 13:43:39, Jói wrote: > Can ...
6 years, 9 months ago (2014-02-28 14:28:04 UTC) #4
Jói
LGTM
6 years, 9 months ago (2014-02-28 14:40:25 UTC) #5
tfarina
TBRing Lei for chrome/ changes. Joi covers google_apis/gcm, since changes there are trivial (he is ...
6 years, 9 months ago (2014-02-28 14:44:40 UTC) #6
tfarina
+Lei, this time.
6 years, 9 months ago (2014-02-28 14:45:13 UTC) #7
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 9 months ago (2014-02-28 14:45:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/183953005/60001
6 years, 9 months ago (2014-02-28 14:45:53 UTC) #9
bcwhite
lgtm
6 years, 9 months ago (2014-02-28 18:10:17 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 18:34:14 UTC) #11
Message was sent while issue was closed. 
Change committed as 254177

Powered by Google App Engine
This is Rietveld 408576698