Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Side by Side Diff: base/file_util_unittest.cc

Issue 183953004: POSIX: CHECK() that file_util::ScopedFD fulfills promise. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix IOS compile failure. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/file_util.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "build/build_config.h" 5 #include "build/build_config.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #include <shellapi.h> 9 #include <shellapi.h>
10 #include <shlobj.h> 10 #include <shlobj.h>
11 #include <tchar.h> 11 #include <tchar.h>
12 #include <winioctl.h> 12 #include <winioctl.h>
13 #endif 13 #endif
14 14
15 #if defined(OS_POSIX)
16 #include <errno.h>
17 #include <fcntl.h>
18 #include <unistd.h>
19 #endif
20
15 #include <algorithm> 21 #include <algorithm>
16 #include <fstream> 22 #include <fstream>
17 #include <set> 23 #include <set>
18 24
19 #include "base/base_paths.h" 25 #include "base/base_paths.h"
20 #include "base/file_util.h" 26 #include "base/file_util.h"
21 #include "base/files/file_enumerator.h" 27 #include "base/files/file_enumerator.h"
22 #include "base/files/file_path.h" 28 #include "base/files/file_path.h"
23 #include "base/files/scoped_temp_dir.h" 29 #include "base/files/scoped_temp_dir.h"
24 #include "base/path_service.h" 30 #include "base/path_service.h"
(...skipping 2431 matching lines...) Expand 10 before | Expand all | Expand 10 after
2456 // Size should be smaller than 0. 2462 // Size should be smaller than 0.
2457 int64 size; 2463 int64 size;
2458 EXPECT_FALSE(GetFileSize(path, &size)); 2464 EXPECT_FALSE(GetFileSize(path, &size));
2459 2465
2460 // We should not be able to read the file. 2466 // We should not be able to read the file.
2461 int fd = OpenContentUriForRead(path); 2467 int fd = OpenContentUriForRead(path);
2462 EXPECT_EQ(-1, fd); 2468 EXPECT_EQ(-1, fd);
2463 } 2469 }
2464 #endif 2470 #endif
2465 2471
2472 TEST(ScopedFD, ScopedFDDoesClose) {
2473 int fds[2];
2474 char c = 0;
2475 ASSERT_EQ(0, pipe(fds));
2476 const int write_end = fds[1];
2477 file_util::ScopedFDCloser read_end_closer(fds);
2478 {
2479 file_util::ScopedFDCloser write_end_closer(fds + 1);
2480 }
2481 // This is the only thread. This file descriptor should no longer be valid.
2482 int ret = close(write_end);
2483 EXPECT_EQ(-1, ret);
2484 EXPECT_EQ(EBADF, errno);
2485 // Make sure read(2) won't block.
2486 ASSERT_EQ(0, fcntl(fds[0], F_SETFL, O_NONBLOCK));
2487 // Reading the pipe should EOF.
2488 EXPECT_EQ(0, read(fds[0], &c, 1));
2489 }
2490
2491 #if defined(GTEST_HAS_DEATH_TEST)
2492 void CloseWithScopedFD(int fd) {
2493 file_util::ScopedFDCloser fd_closer(&fd);
2494 }
2495 #endif
2496
2497 TEST(ScopedFD, ScopedFDCrashesOnCloseFailure) {
2498 int fds[2];
2499 ASSERT_EQ(0, pipe(fds));
2500 file_util::ScopedFDCloser read_end_closer(fds);
2501 EXPECT_EQ(0, IGNORE_EINTR(close(fds[1])));
2502 #if defined(GTEST_HAS_DEATH_TEST)
2503 // This is the only thread. This file descriptor should no longer be valid.
2504 // Trying to close it should crash. This is important for security.
2505 EXPECT_DEATH(CloseWithScopedFD(fds[1]), "");
2506 #endif
2507 }
2508
2466 #endif // defined(OS_POSIX) 2509 #endif // defined(OS_POSIX)
2467 2510
2468 } // namespace 2511 } // namespace
2469 2512
2470 } // namespace base 2513 } // namespace base
OLDNEW
« no previous file with comments | « base/file_util.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698