Updates to the Android.mk writer.

platform_tools/android/bin/gyp_to_android.py

Index: platform_tools/android/bin/gyp_to_android.py
diff --git a/platform_tools/android/bin/gyp_to_android.py b/platform_tools/android/bin/gyp_to_android.py
index 7990ae9d8b97acf0269f193b20b1230eef29d428..7e1ea13277dc9d87e70519efdd6a335eb92ece78 100644
--- a/platform_tools/android/bin/gyp_to_android.py
+++ b/platform_tools/android/bin/gyp_to_android.py
@@ -27,7 +27,6 @@ sys.path.append(GYP_GEN_DIR)
 
 import gypd_parser
 import makefile_writer
-import variables
 import vars_dict_lib
 
 # Folder containing all gyp files and generated gypd files.
@@ -101,17 +100,15 @@ def main(target_dir=None):
     arm_var_dict = generate_var_dict(tmp_folder, main_gyp_file, 'arm', False)
     arm_neon_var_dict = generate_var_dict(tmp_folder, main_gyp_file, 'arm',
                                           True)
-    if variables.INCLUDE_X86_OPTS:
-      x86_var_dict = generate_var_dict(tmp_folder, main_gyp_file, 'x86', False)
-    else:
-      x86_var_dict = None
+    x86_var_dict = generate_var_dict(tmp_folder, main_gyp_file, 'x86', False)
+
+    mips_var_dict = generate_var_dict(tmp_folder, main_gyp_file, 'mips', False)
 
     # Compute the intersection of all targets. All the files in the intersection
     # should be part of the makefile always. Each dict will now contain trimmed
     # lists containing only variable definitions specific to that configuration.
-    var_dict_list = [default_var_dict, arm_var_dict, arm_neon_var_dict]
-    if variables.INCLUDE_X86_OPTS:
-      var_dict_list.append(x86_var_dict)
+    var_dict_list = [default_var_dict, arm_var_dict, arm_neon_var_dict,
+                     x86_var_dict, mips_var_dict]
     common = vars_dict_lib.intersect(var_dict_list)
 
     # Further trim arm_neon_var_dict with arm_var_dict. After this call,
@@ -120,12 +117,20 @@ def main(target_dir=None):
     # those specific to arm + neon.
     arm_var_dict = vars_dict_lib.intersect([arm_var_dict, arm_neon_var_dict])
 
+    # Now create a list of VarsDictData holding everything but common.
+    li = list()

[epoger, 2014/02/28 15:56:43]

Please use a more descriptive variable name.  Maybe deviations_from_common ?

Much less importantly, I think it's more common to initialize the empty list
like so:
li = []

[scroggo, 2014/02/28 16:16:57]

Done.

+    li.append(makefile_writer.VarsDictData(arm_var_dict, 'arm'))
+    li.append(makefile_writer.VarsDictData(arm_neon_var_dict, 'arm',
+                                           'ARCH_ARM_HAVE_NEON'))
+    li.append(makefile_writer.VarsDictData(x86_var_dict, 'x86'))
+    # Currently, x86_64 is identical to x86
+    li.append(makefile_writer.VarsDictData(x86_var_dict, 'x86_64'))
+
+    li.append(makefile_writer.VarsDictData(mips_var_dict, 'mips'))
+
     makefile_writer.write_android_mk(target_dir=target_dir,
                                      common=common,
-                                     arm=arm_var_dict,
-                                     arm_neon=arm_neon_var_dict,
-                                     x86=x86_var_dict,
-                                     default=default_var_dict)
+                                     the_rest=li)
 
   finally:
     shutil.rmtree(tmp_folder)