Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: base/trace_event/heap_profiler_allocation_context.cc

Issue 1839503002: [tracing] Add native allocation tracing mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add type to StackFrame; format thread name Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/heap_profiler_allocation_context.cc
diff --git a/base/trace_event/heap_profiler_allocation_context.cc b/base/trace_event/heap_profiler_allocation_context.cc
index 038c083f0fa83241f9fef46c0ed239572d282d62..b6b711284d2568a88fb460e7855456a335e836ee 100644
--- a/base/trace_event/heap_profiler_allocation_context.cc
+++ b/base/trace_event/heap_profiler_allocation_context.cc
@@ -12,6 +12,18 @@
namespace base {
namespace trace_event {
+bool operator < (const StackFrame& lhs, const StackFrame& rhs) {
+ return lhs.value < rhs.value;
+}
+
+bool operator == (const StackFrame& lhs, const StackFrame& rhs) {
+ return lhs.value == rhs.value;
+}
+
+bool operator != (const StackFrame& lhs, const StackFrame& rhs) {
+ return lhs.value != rhs.value;
+}
+
// Constructor that does not initialize members.
AllocationContext::AllocationContext() {}
@@ -20,7 +32,7 @@ AllocationContext AllocationContext::Empty() {
AllocationContext ctx;
for (size_t i = 0; i < arraysize(ctx.backtrace.frames); i++)
- ctx.backtrace.frames[i] = nullptr;
+ ctx.backtrace.frames[i] = StackFrame::Empty();
ctx.type_name = nullptr;
@@ -43,6 +55,11 @@ bool operator==(const AllocationContext& lhs, const AllocationContext& rhs) {
namespace BASE_HASH_NAMESPACE {
using base::trace_event::AllocationContext;
using base::trace_event::Backtrace;
+using base::trace_event::StackFrame;
+
+size_t hash<StackFrame>::operator()(const StackFrame& frame) const {
+ return this->hash<const void*>::operator()(frame.value);
+}
size_t hash<Backtrace>::operator()(const Backtrace& backtrace) const {
return base::SuperFastHash(reinterpret_cast<const char*>(backtrace.frames),

Powered by Google App Engine
This is Rietveld 408576698