Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4126)

Unified Diff: base/trace_event/heap_profiler_stack_frame_deduplicator.h

Issue 1839503002: [tracing] Add native allocation tracing mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: WalkStackFrames (wants frame pointers) Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/heap_profiler_stack_frame_deduplicator.h
diff --git a/base/trace_event/heap_profiler_stack_frame_deduplicator.h b/base/trace_event/heap_profiler_stack_frame_deduplicator.h
index 4932534e1d790a578290effd9590bc0fe43a64bb..b686f866e1168632f40c8da07c019112bb1d8ab8 100644
--- a/base/trace_event/heap_profiler_stack_frame_deduplicator.h
+++ b/base/trace_event/heap_profiler_stack_frame_deduplicator.h
@@ -30,10 +30,13 @@ class BASE_EXPORT StackFrameDeduplicator : public ConvertableToTraceFormat {
public:
// A node in the call tree.
struct FrameNode {
- FrameNode(StackFrame frame, int parent_frame_index);
+ FrameNode(StackFrameType frame_type,
+ StackFrame frame,
+ int parent_frame_index);
FrameNode(const FrameNode& other);
~FrameNode();
+ StackFrameType frame_type;
StackFrame frame;
// The index of the parent stack frame in |frames_|, or -1 if there is no
@@ -53,7 +56,8 @@ class BASE_EXPORT StackFrameDeduplicator : public ConvertableToTraceFormat {
// (e.g. main) and |endFrame| is a pointer past the top frame (most recently
// called function), and returns the index of its leaf node in |frames_|.
// Returns -1 if the backtrace is empty.
- int Insert(const StackFrame* beginFrame, const StackFrame* endFrame);
+ int Insert(StackFrameType frame_type,
+ const StackFrame* beginFrame, const StackFrame* endFrame);
// Iterators over the frame nodes in the call tree.
ConstIterator begin() const { return frames_.begin(); }

Powered by Google App Engine
This is Rietveld 408576698