Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: base/trace_event/heap_profiler_allocation_context.h

Issue 1839503002: [tracing] Add native allocation tracing mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: WalkStackFrames (wants frame pointers) Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/heap_profiler_allocation_context.h
diff --git a/base/trace_event/heap_profiler_allocation_context.h b/base/trace_event/heap_profiler_allocation_context.h
index 8544c78eb2cd34c3f7693fa4063ccdcf85f837a1..48670680b7083e28b74ec54483e84643033150c8 100644
--- a/base/trace_event/heap_profiler_allocation_context.h
+++ b/base/trace_event/heap_profiler_allocation_context.h
@@ -35,9 +35,15 @@ namespace trace_event {
//
// See the design doc (https://goo.gl/4s7v7b) for more details.
-using StackFrame = const char*;
+using StackFrame = const void*;
+
+enum StackFrameType {
Primiano Tucci (use gerrit) 2016/04/01 15:56:28 do we really need this run-time information per ea
Dmitry Skiba 2016/04/04 22:38:33 It's called that way, but it's used per backtrace,
+ STACK_FRAME_TYPE_SYMBOL, // const char* string
+ STACK_FRAME_TYPE_PC // as returned by StackTrace::Addresses()
+};
struct BASE_EXPORT Backtrace {
+ StackFrameType frame_type;
// Unused backtrace frames are filled with nullptr frames. If the stack is
// higher than what can be stored here, the bottom frames are stored. Based
// on the data above, a depth of 12 captures the full stack in the vast

Powered by Google App Engine
This is Rietveld 408576698