Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: PRESUBMIT.py

Issue 1839453002: Move use of ShutdownWatcherHelper after early return (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: moar Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/lifetime/application_lifetime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 ( 161 (
162 'New code should not use ScopedAllowIO. Post a task to the blocking', 162 'New code should not use ScopedAllowIO. Post a task to the blocking',
163 'pool or the FILE thread instead.', 163 'pool or the FILE thread instead.',
164 ), 164 ),
165 True, 165 True,
166 ( 166 (
167 r"^base[\\\/]process[\\\/]process_linux\.cc$", 167 r"^base[\\\/]process[\\\/]process_linux\.cc$",
168 r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$", 168 r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$",
169 r"^blimp[\\\/]engine[\\\/]app[\\\/]blimp_browser_main_parts\.cc$", 169 r"^blimp[\\\/]engine[\\\/]app[\\\/]blimp_browser_main_parts\.cc$",
170 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_recorder\.cc$", 170 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_recorder\.cc$",
171 r"^chrome[\\\/]browser[\\\/]lifetime[\\\/]application_lifetime\.cc$",
171 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]" 172 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]"
172 "customization_document_browsertest\.cc$", 173 "customization_document_browsertest\.cc$",
173 r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$", 174 r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$",
174 r"^content[\\\/]shell[\\\/]browser[\\\/]layout_test[\\\/]" + 175 r"^content[\\\/]shell[\\\/]browser[\\\/]layout_test[\\\/]" +
175 r"test_info_extractor\.cc$", 176 r"test_info_extractor\.cc$",
176 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$", 177 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$",
177 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$", 178 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$",
178 r"^mojo[\\\/]edk[\\\/]embedder[\\\/]" + 179 r"^mojo[\\\/]edk[\\\/]embedder[\\\/]" +
179 r"simple_platform_shared_buffer_posix\.cc$", 180 r"simple_platform_shared_buffer_posix\.cc$",
180 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$", 181 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$",
(...skipping 1793 matching lines...) Expand 10 before | Expand all | Expand 10 after
1974 results.extend(input_api.canned_checks.CheckTreeIsOpen( 1975 results.extend(input_api.canned_checks.CheckTreeIsOpen(
1975 input_api, 1976 input_api,
1976 output_api, 1977 output_api,
1977 json_url='http://chromium-status.appspot.com/current?format=json')) 1978 json_url='http://chromium-status.appspot.com/current?format=json'))
1978 1979
1979 results.extend(input_api.canned_checks.CheckChangeHasBugField( 1980 results.extend(input_api.canned_checks.CheckChangeHasBugField(
1980 input_api, output_api)) 1981 input_api, output_api))
1981 results.extend(input_api.canned_checks.CheckChangeHasDescription( 1982 results.extend(input_api.canned_checks.CheckChangeHasDescription(
1982 input_api, output_api)) 1983 input_api, output_api))
1983 return results 1984 return results
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/lifetime/application_lifetime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698