Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1839443002: Fix for labels and the 'inDeclarationContext' flag. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 2 chunks +27 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
scheglov
4 years, 9 months ago (2016-03-25 19:13:00 UTC) #1
Brian Wilkerson
lgtm, but you should add Bob as a reviewer.
4 years, 9 months ago (2016-03-25 19:27:47 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as f6e4f4c053b524f1c3f92e1b490fe9ccd9615ca6 (presubmit successful).
4 years, 8 months ago (2016-03-28 15:44:46 UTC) #6
Bob Nystrom
4 years, 8 months ago (2016-03-28 15:58:55 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698