Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1839433002: [Media Router WebUI] Switch on-click to on-tap for consistent event listening. (Closed)

Created:
4 years, 9 months ago by apacible
Modified:
4 years, 9 months ago
Reviewers:
mark a. foltz
CC:
arv+watch_chromium.org, chromium-reviews, media-router+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Switch on-click to on-tap for consistent event listening. Previously, we used on-click for user click events, which made touch screen interactions inconsistent. This change switches all on-click listeners to on-tap, which listens for a event that fires consistently on touch/click platforms. Tested with the --simulate-touch-screen-with-mouse and enabling touch events in Chrome DevTools. BUG=596844 Committed: https://crrev.com/b6d78f039a327f70412ccdb2c03a341c7f1fc8af Cr-Commit-Position: refs/heads/master@{#383395}

Patch Set 1 : #

Messages

Total messages: 14 (8 generated)
apacible
PTAL, thanks!
4 years, 9 months ago (2016-03-25 19:40:12 UTC) #6
mark a. foltz
lgtm It might be worth verifying things work as expected on a touch screen chromebook ...
4 years, 9 months ago (2016-03-25 22:13:05 UTC) #7
apacible
On 2016/03/25 22:13:05, mark a. foltz wrote: > lgtm > > It might be worth ...
4 years, 9 months ago (2016-03-25 23:00:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839433002/20001
4 years, 9 months ago (2016-03-25 23:00:36 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 9 months ago (2016-03-25 23:07:17 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 23:09:35 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6d78f039a327f70412ccdb2c03a341c7f1fc8af
Cr-Commit-Position: refs/heads/master@{#383395}

Powered by Google App Engine
This is Rietveld 408576698