test/mjsunit/wasm/asm-wasm-i32.js - Issue 1839333002: [wasm] Fix asm.js semantics for divide by zero in WASM translation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/mjsunit/wasm/asm-wasm-i32.js

Issue 1839333002: [wasm] Fix asm.js semantics for divide by zero in WASM translation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Small code simplifications. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/mjsunit/wasm/asm-wasm-i32.js

diff --git a/test/mjsunit/wasm/asm-wasm-i32.js b/test/mjsunit/wasm/asm-wasm-i32.js

index 5e13c72b80494192541001483af7047941430830..1b4d3a978c41749674d358cdcf5ce3468a519c6e 100644

--- a/test/mjsunit/wasm/asm-wasm-i32.js

+++ b/test/mjsunit/wasm/asm-wasm-i32.js

@@ -213,9 +213,8 @@ var funcs = [

i32_add,

i32_sub,

i32_mul,

- // TODO(titzer): i32_mul requires Math.imul

- // TODO(titzer): i32_div divide by zero is incorrect

- // TODO(titzer): i32_mod by zero is incorrect

+ i32_div,

+ i32_mod,

i32_and,

i32_or,

i32_xor,

« no previous file with comments | « test/cctest/wasm/test-run-wasm.cc ('k') | test/mjsunit/wasm/asm-wasm-u32.js » ('j') | no next file with comments »