Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 183933002: Remove old WebSourceBufferImpl::append() (Closed)

Created:
6 years, 9 months ago by wolenetz
Modified:
6 years, 9 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Remove old WebSourceBufferImpl::append() This is the third part of a three-sided MediaSource Chromium/Blink+roll Blink/Chromium set of changes to enable JavaScript web apps to continue to round-trip SourceBuffer.timestampOffset set/get if SourceBuffer append operations do not update the timestamp offset, and to retrieve any updated timestamp offset as can occur during upcoming "sequence" append mode compliant coded frame processing. This change removes the obsolete Chromium WebSourceBufferImpl::append(,) now that Blink WebSourceBuffer.h only has append(,,double*). R=acolwell@chromium.org BUG=249422 TEST=All media_unittests and http/tests/media/media-source layout tests pass locally on Linux Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255373

Patch Set 1 #

Patch Set 2 : Rebased after the first (chromium) part landed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M content/renderer/media/websourcebuffer_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/media/websourcebuffer_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
wolenetz
Please take a look. This depends on the first two parts landing first, and Blink ...
6 years, 9 months ago (2014-02-27 22:12:30 UTC) #1
wolenetz
PS2 has no change, just me fixing up my local git branches after the first ...
6 years, 9 months ago (2014-02-28 19:31:25 UTC) #2
acolwell GONE FROM CHROMIUM
lgtm
6 years, 9 months ago (2014-03-06 00:15:07 UTC) #3
wolenetz
The CQ bit was checked by wolenetz@chromium.org
6 years, 9 months ago (2014-03-06 00:33:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/183933002/40001
6 years, 9 months ago (2014-03-06 00:34:57 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 01:42:07 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275895
6 years, 9 months ago (2014-03-06 01:42:08 UTC) #7
wolenetz
The CQ bit was checked by wolenetz@chromium.org
6 years, 9 months ago (2014-03-06 14:46:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/183933002/40001
6 years, 9 months ago (2014-03-06 14:46:55 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 14:48:59 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-06 14:49:00 UTC) #11
wolenetz
The CQ bit was checked by wolenetz@chromium.org
6 years, 9 months ago (2014-03-06 14:59:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/183933002/40001
6 years, 9 months ago (2014-03-06 15:00:14 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 16:56:25 UTC) #14
Message was sent while issue was closed.
Change committed as 255373

Powered by Google App Engine
This is Rietveld 408576698