Move _changingHistoryState to superclass.

Move _changingHistoryState to superclass.

Move _changingHistoryState boolean to CRWWebController.

BUG=579697
Committed: https://crrev.com/5bbe669d786b1d5b774593960aebd232024d4e07
Cr-Commit-Position: refs/heads/master@{#384304}

[michaeldo, 2016-03-30 16:34:10]

michaeldo@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-03-30 16:56:21]

Please use BUG=579697 for UIWebView cleanups

https://codereview.chromium.org/1839323003/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller+protected.h (right):

https://codereview.chromium.org/1839323003/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller+protected.h:95: -
(SEL)selectorToHandleJavaScriptCommand:(const std::string&)command;
Drop this.

https://codereview.chromium.org/1839323003/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/1839323003/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:2409: // This dummy handler is a
workaround for crbug.com/490673. Issue was
This comment needs to be revised as handler is not empty anymore.
crbug.com/490673 was probably related to UIWebView. Could you please test with
current up if removing this handler causes crbug.com/490673 to show up again?

[michaeldo, 2016-03-30 17:04:17]

https://codereview.chromium.org/1839323003/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller+protected.h (right):

https://codereview.chromium.org/1839323003/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller+protected.h:95: -
(SEL)selectorToHandleJavaScriptCommand:(const std::string&)command;
On 2016/03/30 16:56:21, eugenebut wrote:
> Drop this.

Done.

https://codereview.chromium.org/1839323003/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/1839323003/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:2409: // This dummy handler is a
workaround for crbug.com/490673. Issue was
On 2016/03/30 16:56:21, eugenebut wrote:
> This comment needs to be revised as handler is not empty anymore.
> crbug.com/490673 was probably related to UIWebView. Could you please test with
> current up if removing this handler causes crbug.com/490673 to show up again?

I will re-verify.

[michaeldo, 2016-03-30 17:04:30]

Description was changed from

==========
Move _changingHistoryState to superclass.

Move _changingHistoryState boolean to CRWWebController.

BUG=none
==========

to

==========
Move _changingHistoryState to superclass.

Move _changingHistoryState boolean to CRWWebController.

BUG= 579697
==========

[michaeldo, 2016-03-30 21:49:07]

https://codereview.chromium.org/1839323003/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/1839323003/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:2409: // This dummy handler is a
workaround for crbug.com/490673. Issue was
On 2016/03/30 17:04:17, michaeldo wrote:
> On 2016/03/30 16:56:21, eugenebut wrote:
> > This comment needs to be revised as handler is not empty anymore.
> > crbug.com/490673 was probably related to UIWebView. Could you please test
with
> > current up if removing this handler causes crbug.com/490673 to show up
again?
> 
> I will re-verify.

That bug is actually reproducible on master irregardless of this change. I've
removed the comment as it no longer applies.

[Eugene But (OOO till 7-30), 2016-03-30 23:32:12]

lgtm

[michaeldo, 2016-03-31 16:08:49]

The CQ bit was checked by michaeldo@chromium.org

[commit-bot: I haz the power, 2016-03-31 16:09:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1839323003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1839323003/20001

[commit-bot: I haz the power, 2016-03-31 16:42:15]

Description was changed from

==========
Move _changingHistoryState to superclass.

Move _changingHistoryState boolean to CRWWebController.

BUG= 579697
==========

to

==========
Move _changingHistoryState to superclass.

Move _changingHistoryState boolean to CRWWebController.

BUG= 579697
==========

[commit-bot: I haz the power, 2016-03-31 16:42:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-31 16:43:38]

Description was changed from

==========
Move _changingHistoryState to superclass.

Move _changingHistoryState boolean to CRWWebController.

BUG= 579697
==========

to

==========
Move _changingHistoryState to superclass.

Move _changingHistoryState boolean to CRWWebController.

BUG= 579697

Committed: https://crrev.com/5bbe669d786b1d5b774593960aebd232024d4e07
Cr-Commit-Position: refs/heads/master@{#384304}
==========

[commit-bot: I haz the power, 2016-03-31 16:43:39]

Patchset 2 (id:??) landed as
https://crrev.com/5bbe669d786b1d5b774593960aebd232024d4e07
Cr-Commit-Position: refs/heads/master@{#384304}