Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1839303002: Removed mac valgrind test exclusions and suppressions. (Closed)

Created:
4 years, 8 months ago by benwells
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, glider+watch_chromium.org, toyoshim+midi_chromium.org, bruening+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed mac valgrind test exclusions and suppressions. The mac valgrind bot doesn't exist anymore, so no need for these suppressions and exclusions. BUG=593920 Committed: https://crrev.com/d8464b0b4b8fcad7448f48a36bb6b73834a41830 Cr-Commit-Position: refs/heads/master@{#383921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -459 lines) Patch
D tools/valgrind/gtest_exclude/base_unittests.gtest_mac.txt View 1 chunk +0 lines, -27 lines 0 comments Download
D tools/valgrind/gtest_exclude/content_unittests.gtest_mac.txt View 1 chunk +0 lines, -71 lines 0 comments Download
D tools/valgrind/gtest_exclude/ipc_tests.gtest_mac.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D tools/valgrind/gtest_exclude/media_unittests.gtest_mac.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D tools/valgrind/gtest_exclude/midi_unittests.gtest_mac.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D tools/valgrind/gtest_exclude/net_unittests.gtest_mac.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D tools/valgrind/gtest_exclude/remoting_unittests.gtest_mac.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D tools/valgrind/gtest_exclude/safe_browsing_tests.gtest_mac.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D tools/valgrind/memcheck/suppressions_mac.txt View 1 chunk +0 lines, -330 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
benwells
4 years, 8 months ago (2016-03-30 06:03:15 UTC) #2
Lei Zhang
lgtm Goodbye Valgrind Mac!
4 years, 8 months ago (2016-03-30 06:55:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839303002/1
4 years, 8 months ago (2016-03-30 07:01:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 07:35:49 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 07:37:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8464b0b4b8fcad7448f48a36bb6b73834a41830
Cr-Commit-Position: refs/heads/master@{#383921}

Powered by Google App Engine
This is Rietveld 408576698