MD Settings: simplify logic for whether themes can be reset

MD Settings: simplify logic for whether themes can be reset

R=dpapad@chromium.org
BUG=531786
Committed: https://crrev.com/eb23e99695bcc26071977666784c84a483223302
Cr-Commit-Position: refs/heads/master@{#384164}

[dpapad, 2016-03-30 17:15:26]

LGTM

https://codereview.chromium.org/1839293002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/appearance_handler.cc (right):

https://codereview.chromium.org/1839293002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/appearance_handler.cc:58: Profile* profile =
Profile::FromWebUI(web_ui());
Nit(optional): Unnecessary local var, since profile_ member var can be used.

https://codereview.chromium.org/1839293002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/appearance_handler.cc:73:
ResolveJavascriptCallback(*callback_id, enabled);
Nit(optional): Maybe Inline local var.

ResolveJavascriptCallback(
    *callback_id, base::FundamentalValue(ResetThemeEnabled());

[Dan Beam, 2016-03-30 23:22:38]

https://codereview.chromium.org/1839293002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/appearance_handler.cc (right):

https://codereview.chromium.org/1839293002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/appearance_handler.cc:58: Profile* profile =
Profile::FromWebUI(web_ui());
On 2016/03/30 17:15:26, dpapad wrote:
> Nit(optional): Unnecessary local var, since profile_ member var can be used.

Done.

https://codereview.chromium.org/1839293002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/appearance_handler.cc:73:
ResolveJavascriptCallback(*callback_id, enabled);
On 2016/03/30 17:15:26, dpapad wrote:
> Nit(optional): Maybe Inline local var.
> 
> ResolveJavascriptCallback(
>     *callback_id, base::FundamentalValue(ResetThemeEnabled());

Done.

[Dan Beam, 2016-03-30 23:26:27]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-03-30 23:26:27]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/1839293002/#ps20001
(title: "simpler")

[commit-bot: I haz the power, 2016-03-30 23:26:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1839293002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1839293002/20001

[commit-bot: I haz the power, 2016-03-31 00:40:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-31 00:43:14]

Description was changed from

==========
MD Settings: simplify logic for whether themes can be reset

R=dpapad@chromium.org
BUG=531786
==========

to

==========
MD Settings: simplify logic for whether themes can be reset

R=dpapad@chromium.org
BUG=531786

Committed: https://crrev.com/eb23e99695bcc26071977666784c84a483223302
Cr-Commit-Position: refs/heads/master@{#384164}
==========

[commit-bot: I haz the power, 2016-03-31 00:43:15]

Patchset 2 (id:??) landed as
https://crrev.com/eb23e99695bcc26071977666784c84a483223302
Cr-Commit-Position: refs/heads/master@{#384164}