Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1219)

Issue 1839243005: Turn scavenge_reclaim_unmodified_objects on by default (Closed)

Created:
4 years, 8 months ago by Marcel Hlopko
Modified:
4 years, 8 months ago
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turn scavenge_reclaim_unmodified_objects on by default Embedders that rely on unmodified wrappers to survive should pass the command-line flag --noscavenge_reclaim_unmodified_objects BUG=4880 LOG=yes Committed: https://crrev.com/5951a5898348aba8cb980b09230a9d08250ba627 Cr-Commit-Position: refs/heads/master@{#35164}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Marcel Hlopko
4 years, 8 months ago (2016-03-31 13:25:10 UTC) #2
jochen (gone - plz use gerrit)
lgtm please modify the CL description to say "LOG=yes" as this might affect embedders. You ...
4 years, 8 months ago (2016-03-31 13:26:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839243005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839243005/1
4 years, 8 months ago (2016-03-31 13:29:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 13:50:36 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 13:51:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5951a5898348aba8cb980b09230a9d08250ba627
Cr-Commit-Position: refs/heads/master@{#35164}

Powered by Google App Engine
This is Rietveld 408576698