Suppress deprecation warnings for OS X sandbox functions.

Suppress deprecation warnings for OS X sandbox functions.

OS X deprecated sandbox_init and sandbox_free_error, but never
provided suitable replacements. This supresses the warning.

BUG=547071
Committed: https://crrev.com/4a7c8037156d284abd840ce093c001655ec4f742
Cr-Commit-Position: refs/heads/master@{#384310}

[Greg K, 2016-03-30 20:08:36]

kerrnel@chromium.org changed reviewers:
+ rsesek@chromium.org

[Greg K, 2016-03-30 20:08:36]

Please review, thanks.

[Robert Sesek, 2016-03-30 20:38:52]

I think there's one more instance of this in crdmg.cc.

One thing to consider would be to add //sandbox/mac/seatbelt.h that wraps these
functions in a C++ class to hide the #pragma's.

[Greg K, 2016-03-30 20:48:33]

On 2016/03/30 20:38:52, Robert Sesek wrote:
> I think there's one more instance of this in crdmg.cc.
> 
> One thing to consider would be to add //sandbox/mac/seatbelt.h that wraps
these
> functions in a C++ class to hide the #pragma's.

Yes, the instance in crdmg.cc is already wrapped in pragma's. Should we replace
them all with C++ versions? In theory we could also use
sandbox_init_with_parameters and pass an empty parameters, although that is a
bit more hacky.

[Robert Sesek, 2016-03-30 20:54:02]

On 2016/03/30 20:48:33, Greg Kerr wrote:
> On 2016/03/30 20:38:52, Robert Sesek wrote:
> > I think there's one more instance of this in crdmg.cc.
> > 
> > One thing to consider would be to add //sandbox/mac/seatbelt.h that wraps
> these
> > functions in a C++ class to hide the #pragma's.
> 
> Yes, the instance in crdmg.cc is already wrapped in pragma's. Should we
replace
> them all with C++ versions?

Ah, how thoughtful of me!

> In theory we could also use
> sandbox_init_with_parameters and pass an empty parameters, although that is a
> bit more hacky.

That would require everyone to forward-declare sandbox_init_with_parameters, and
it doesn't solve the sandbox_error_free issue. This LGTM; creating something in
//sandbox/mac is optional.

[Greg K, 2016-03-30 20:58:15]

kerrnel@chromium.org changed reviewers:
+ tsepez@chromium.org

[Greg K, 2016-03-30 20:58:15]

tsepez@chromium.org: Please provide an OWNERS review for the ipc file.

Thanks,

kerrnel

[Tom Sepez, 2016-03-30 21:25:51]

STAMP LGTM.

[Greg K, 2016-03-31 16:32:31]

The CQ bit was checked by kerrnel@chromium.org

[commit-bot: I haz the power, 2016-03-31 16:32:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1839243004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1839243004/1

[commit-bot: I haz the power, 2016-03-31 16:57:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-31 17:04:30]

Description was changed from

==========
Suppress deprecation warnings for OS X sandbox functions.

OS X deprecated sandbox_init and sandbox_free_error, but never
provided suitable replacements. This supresses the warning.

BUG=547071
==========

to

==========
Suppress deprecation warnings for OS X sandbox functions.

OS X deprecated sandbox_init and sandbox_free_error, but never
provided suitable replacements. This supresses the warning.

BUG=547071

Committed: https://crrev.com/4a7c8037156d284abd840ce093c001655ec4f742
Cr-Commit-Position: refs/heads/master@{#384310}
==========

[commit-bot: I haz the power, 2016-03-31 17:04:31]

Patchset 1 (id:??) landed as
https://crrev.com/4a7c8037156d284abd840ce093c001655ec4f742
Cr-Commit-Position: refs/heads/master@{#384310}

[Nico, 2016-03-31 19:50:14]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-03-31 19:50:15]

https://codereview.chromium.org/1839243004/diff/1/content/common/sandbox_mac.mm
File content/common/sandbox_mac.mm (right):

https://codereview.chromium.org/1839243004/diff/1/content/common/sandbox_mac....
content/common/sandbox_mac.mm:157: error->assign(error_internal);
Can you please add a somewhat detailed comment here why this suppression is
justified? I think this CL is ok, but I don't want unannotated instances of this
suppression in the code base.

https://codereview.chromium.org/1839243004/diff/1/ipc/ipc_send_fds_test.cc
File ipc/ipc_send_fds_test.cc (right):

https://codereview.chromium.org/1839243004/diff/1/ipc/ipc_send_fds_test.cc#ne...
ipc/ipc_send_fds_test.cc:197: #pragma clang diagnostic ignored
"-Wdeprecated-declarations"
Here too

[Greg K, 2016-03-31 20:02:36]

On 2016/03/31 19:50:15, Nico wrote:
>
https://codereview.chromium.org/1839243004/diff/1/content/common/sandbox_mac.mm
> File content/common/sandbox_mac.mm (right):
> 
>
https://codereview.chromium.org/1839243004/diff/1/content/common/sandbox_mac....
> content/common/sandbox_mac.mm:157: error->assign(error_internal);
> Can you please add a somewhat detailed comment here why this suppression is
> justified? I think this CL is ok, but I don't want unannotated instances of
this
> suppression in the code base.
> 
> https://codereview.chromium.org/1839243004/diff/1/ipc/ipc_send_fds_test.cc
> File ipc/ipc_send_fds_test.cc (right):
> 
>
https://codereview.chromium.org/1839243004/diff/1/ipc/ipc_send_fds_test.cc#ne...
> ipc/ipc_send_fds_test.cc:197: #pragma clang diagnostic ignored
> "-Wdeprecated-declarations"
> Here too

Sure, if I am going to comment everything, why don't I just write a C++ wrapper
function so the comment is only in one place?

- Greg

[Nico, 2016-03-31 20:27:50]

Works for me :-)
On Mar 31, 2016 4:02 PM, <kerrnel@chromium.org> wrote:

> On 2016/03/31 19:50:15, Nico wrote:
> >
>
>
https://codereview.chromium.org/1839243004/diff/1/content/common/sandbox_mac.mm
> > File content/common/sandbox_mac.mm (right):
> >
> >
>
>
https://codereview.chromium.org/1839243004/diff/1/content/common/sandbox_mac....
> > content/common/sandbox_mac.mm:157: error->assign(error_internal);
> > Can you please add a somewhat detailed comment here why this suppression
> is
> > justified? I think this CL is ok, but I don't want unannotated instances
> of
> this
> > suppression in the code base.
> >
> >
> https://codereview.chromium.org/1839243004/diff/1/ipc/ipc_send_fds_test.cc
> > File ipc/ipc_send_fds_test.cc (right):
> >
> >
>
>
https://codereview.chromium.org/1839243004/diff/1/ipc/ipc_send_fds_test.cc#ne...
> > ipc/ipc_send_fds_test.cc:197: #pragma clang diagnostic ignored
> > "-Wdeprecated-declarations"
> > Here too
>
> Sure, if I am going to comment everything, why don't I just write a C++
> wrapper
> function so the comment is only in one place?
>
> - Greg
>
> https://codereview.chromium.org/1839243004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.