Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1839243003: Serialize ResolutionImpact instead of WorldImpact. (Closed)

Created:
4 years, 8 months ago by Johnni Winther
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -34 lines) Patch
M pkg/compiler/lib/src/common/resolution.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 5 chunks +20 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/impact_serialization.dart View 4 chunks +125 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/serialization/keys.dart View 4 chunks +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/serialization.dart View 3 chunks +28 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/serialization_analysis_test.dart View 6 chunks +22 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 8 months ago (2016-03-30 11:56:40 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1839243003/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/1839243003/diff/1/pkg/compiler/lib/src/compiler.dart#newcode2029 pkg/compiler/lib/src/compiler.dart:2029: if (compiler.serialization.supportSerialization) { why do we only cache ...
4 years, 8 months ago (2016-03-30 20:29:39 UTC) #3
Johnni Winther
https://codereview.chromium.org/1839243003/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/1839243003/diff/1/pkg/compiler/lib/src/compiler.dart#newcode2029 pkg/compiler/lib/src/compiler.dart:2029: if (compiler.serialization.supportSerialization) { On 2016/03/30 20:29:39, Siggi Cherem (dart-lang) ...
4 years, 8 months ago (2016-03-31 07:50:41 UTC) #4
Johnni Winther
4 years, 8 months ago (2016-03-31 07:55:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
27b2c36ec1dcfa017d588b9328bc7a71de971241 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698