Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2624)

Unified Diff: Tools/GardeningServer/scripts/ui/notifications.js

Issue 183923025: Garden-o-matic: Introduce an option to open links in a new window (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/scripts/ui/notifications.js
diff --git a/Tools/GardeningServer/scripts/ui/notifications.js b/Tools/GardeningServer/scripts/ui/notifications.js
index 8ddaed2bdc92a20e92c146dc6d04c02d3f3b9d1f..466b7b587e56cb071a174b69c092a2e6f1a13499 100644
--- a/Tools/GardeningServer/scripts/ui/notifications.js
+++ b/Tools/GardeningServer/scripts/ui/notifications.js
@@ -96,7 +96,7 @@ ui.notifications.Info = base.extends(ui.notifications.Notification, {
ui.notifications.FailingTestGroup = base.extends('li', {
init: function(groupName, testNameList)
{
- this.appendChild(base.createLinkNode(ui.urlForFlakinessDashboard(testNameList), groupName));
+ this.appendChild(ui.createLinkNode(ui.urlForFlakinessDashboard(testNameList), groupName));
}
});
@@ -112,7 +112,7 @@ ui.notifications.SuspiciousCommit = base.extends(Cause, {
init: function(commitData)
{
this._revision = commitData.revision;
- this._description.appendChild(base.createLinkNode(trac.changesetURL(commitData.revision), commitData.revision));
+ this._description.appendChild(ui.createLinkNode(trac.changesetURL(commitData.revision), commitData.revision));
this._details = this._description.appendChild(document.createElement('span'));
this._addDetail('title', commitData);
this._addDetail('author', commitData);
@@ -142,7 +142,7 @@ ui.notifications.SuspiciousCommit = base.extends(Cause, {
parts.forEach(function(item, index) {
if (index > 0)
span.appendChild(document.createTextNode(', '));
- var link = base.createLinkNode(linkFunction(item), item);
+ var link = ui.createLinkNode(linkFunction(item), item);
link.className = part + '-item';
span.appendChild(link);
});

Powered by Google App Engine
This is Rietveld 408576698