Garden-o-matic: Introduce an option to open links in a new window

Tools/GardeningServer/scripts/ui/notifications.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 78 matching lines @@
     updateWithNode: function(node)
     {
         $(this._what).empty();
         this._what.appendChild(node);
     }
 });
 
 ui.notifications.FailingTestGroup = base.extends('li', {
     init: function(groupName, testNameList)
     {
-        this.appendChild(base.createLinkNode(ui.urlForFlakinessDashboard(testNameList), groupName));
+        this.appendChild(ui.createLinkNode(ui.urlForFlakinessDashboard(testNameList), groupName));
     }
 });
 
 var Cause = base.extends('li', {
     init: function()
     {
         this._description = this.appendChild(document.createElement('div'));
         this._description.className = 'description';
     }
 });
 
 ui.notifications.SuspiciousCommit = base.extends(Cause, {
     init: function(commitData)
     {
         this._revision = commitData.revision;
-        this._description.appendChild(base.createLinkNode(trac.changesetURL(commitData.revision), commitData.revision));
+        this._description.appendChild(ui.createLinkNode(trac.changesetURL(commitData.revision), commitData.revision));
         this._details = this._description.appendChild(document.createElement('span'));
         this._addDetail('title', commitData);
         this._addDetail('author', commitData);
         this._addDetail('reviewer', commitData);
         this._addDetail('bugID', commitData,
             ui.urlForCrbug,
             function(value) {
                 return value.split(/\s*,\s*/);
             }
         );
     },
     hasRevision: function(revision)
     {
         return this._revision == revision;
     },
     _addDetail: function(part, commitData, linkFunction)
     {
         var content = commitData[part];
         if (!content)
             return;
 
         var span = this._details.appendChild(document.createElement('span'));
         span.className = part;
         
         if (linkFunction) {
             var parts = $.isArray(content) ? content : [content];
             parts.forEach(function(item, index) {
                 if (index > 0)
                     span.appendChild(document.createTextNode(', '));
-                var link = base.createLinkNode(linkFunction(item), item);
+                var link = ui.createLinkNode(linkFunction(item), item);
                 link.className = part + '-item';
                 span.appendChild(link);
             });
         } else {
             span.textContent = content;
         }
     }
 });
 
 ui.notifications.Failure = base.extends(ui.notifications.Notification, {
@@ skipping 110 matching lines @@
         $(this._effects).empty().append(Object.keys(failuresList).map(function(builderName) {
             var effect = document.createElement('li');
             effect.className = 'builder';
             effect.appendChild(new ui.failures.Builder(builderName, failuresList[builderName]));
             return effect;
         }));
     }
 });
 
 })();