Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 183923013: Add coverage analysis to push and merge script tests. (Closed)

Created:
6 years, 9 months ago by Michael Achenbach
Modified:
6 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Add coverage analysis to push and merge script tests. The coverage analysis must live in an extra file in order to analyze the scripts when being imported. TEST=tools/push-to-trunk/script_test.py R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19640

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -14 lines) Patch
A + tools/push-to-trunk/script_test.py View 2 chunks +25 lines, -12 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
6 years, 9 months ago (2014-03-02 22:30:25 UTC) #1
ulan
lgtm
6 years, 9 months ago (2014-03-03 08:34:28 UTC) #2
Michael Achenbach
6 years, 9 months ago (2014-03-03 20:17:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19640 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698