Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: chrome/test/data/extensions/api_test/gcm/functions/register_validation/register_validation.js

Issue 183923006: [GCM] API update to allow only a single sender in registration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updates based on CR. Changing how the senders/reg_ids are stored to avoid upgrade to multiple sedne… Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/gcm/functions/register_validation/register_validation.js
diff --git a/chrome/test/data/extensions/api_test/gcm/functions/register_validation/register_validation.js b/chrome/test/data/extensions/api_test/gcm/functions/register_validation/register_validation.js
index 952769f967f14d6899e9801b2b1cf47ba576fd0b..bd6ddc1af996e505e20e2d65f718621c818a4161 100644
--- a/chrome/test/data/extensions/api_test/gcm/functions/register_validation/register_validation.js
+++ b/chrome/test/data/extensions/api_test/gcm/functions/register_validation/register_validation.js
@@ -2,35 +2,17 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-function generateSenderIds(size) {
- var senders = [];
- for (var i = 0; i < size; i++) {
- senders.push("Sender" + i);
- }
- return senders;
-}
-
-function toArrayDefinitionString(senderIds) {
- var idsString = "[";
- senderIds.forEach(function(element, index) {
- if (index > 0) idsString += ", ";
- idsString += "\"" + element + "\"";
- });
- idsString += "]";
- return idsString;
-}
-
-function registerSuccessfully(senderIds) {
- chrome.gcm.register(senderIds, function(registrationId) {
- chrome.test.assertEq("" + senderIds.length, registrationId);
+function registerSuccessfully(senderId) {
+ chrome.gcm.register(senderId, function(registrationId) {
+ chrome.test.assertEq("" + senderId.length, registrationId);
chrome.test.succeed();
});
}
-function registerInvalidParameters(senderIds) {
+function registerInvalidParameters(senderId) {
try {
- chrome.gcm.register(senderIds, function(registrationId) {
- chrome.test.fail("Arguments: " + toArrayDefinitionString(senderIds));
+ chrome.gcm.register(senderId, function(registrationId) {
+ chrome.test.fail("SenderID: " + senderIds);
});
} catch (e) {
chrome.test.succeed();
@@ -38,25 +20,10 @@ function registerInvalidParameters(senderIds) {
}
chrome.test.runTests([
- function successWithOneSender() {
- registerSuccessfully(generateSenderIds(1));
- },
- function successWithMultipleSenders() {
- registerSuccessfully(generateSenderIds(10));
- },
- function successWithMaxSenders() {
- registerSuccessfully(generateSenderIds(100));
- },
- function failureWithNoSenders() {
- registerInvalidParameters([]);
- },
- function failureWithEmptySenderOnly() {
- registerInvalidParameters([""]);
+ function successWithSenderSet() {
+ registerSuccessfully("Single.sender");
},
- function failureWithEmptySender() {
- registerInvalidParameters(["good", ""]);
+ function failureEmptySender() {
+ registerInvalidParameters("");
},
- function failureWithTooManySenders() {
- registerInvalidParameters(generateSenderIds(101));
- }
]);

Powered by Google App Engine
This is Rietveld 408576698