chrome/common/extensions/api/gcm.json - Issue 183923006: [GCM] API update to allow only a single sender in registration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/gcm.json

Issue 183923006: [GCM] API update to allow only a single sender in registration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updates based on CR. Changing how the senders/reg_ids are stored to avoid upgrade to multiple sedne… Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/services/gcm/gcm_profile_service.cc ('K') | « chrome/browser/services/gcm/gcm_profile_service_unittest.cc ('k') | chrome/test/data/extensions/api_test/gcm/functions/incognito/test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/gcm.json

diff --git a/chrome/common/extensions/api/gcm.json b/chrome/common/extensions/api/gcm.json

index 869138a73f0976e02bea6be6f9f1d126f22ea50c..1e5cd3de05dda50714d7a97b37095854cd7aac89 100644

--- a/chrome/common/extensions/api/gcm.json

+++ b/chrome/common/extensions/api/gcm.json

@@ -16,25 +16,20 @@

{

"name": "register",

"type": "function",

- "description": "Registers the application with GCM. The registration ID will be returned by the <code>callback</code>. If <code>register</code> is called again with the same list of <code>senderIds</code>, the same registration ID will be returned.",

+ "description": "Registers the application with GCM. The registration ID will be returned by the <code>callback</code>.",

"parameters": [

{

- "name": "senderIds",

- "type": "array",

- "items": {

- "type": "string",

- "minLength": 1

- },

- "minItems": 1,

- "maxItems": 100,

- "description": "A list of server IDs that are allowed to send messages to the application. It should contain at least one and no more than 100 sender IDs."

+ "name": "senderId",

+ "type": "string",

+ "minLength": 1,

+ "description": "A server ID of a sender that will be allowed to send messages to the application."

{

"name": "callback",

"type": "function",

- "description": "Function called when registration completes. It should check $(ref:runtime.lastError) for error when <code>registrationId</code> is empty.",

+ "description": "Function called when registration completes. It should check $(ref:runtime.lastError) for error when <code>registrationId</code> is empty. If <code>register</code> is called again with the same <code>senderId</code>, the same registration ID will be returned.",

"parameters": [

- {

+ {

"name": "registrationId",

"type": "string",

"description": "A registration ID assigned to the application by the GCM."