chrome/browser/extensions/api/gcm/gcm_apitest.cc - Issue 183923006: [GCM] API update to allow only a single sender in registration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/gcm/gcm_apitest.cc

Issue 183923006: [GCM] API update to allow only a single sender in registration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updates based on CR. Changing how the senders/reg_ids are stored to avoid upgrade to multiple sedne… Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/gcm/gcm_apitest.cc

diff --git a/chrome/browser/extensions/api/gcm/gcm_apitest.cc b/chrome/browser/extensions/api/gcm/gcm_apitest.cc

index 63ec748c06d90d7dc67cbca26314337d6bfd7b21..beeb1ec3ae1704b6e3712c4f2197e6d3aedcebcf 100644

--- a/chrome/browser/extensions/api/gcm/gcm_apitest.cc

+++ b/chrome/browser/extensions/api/gcm/gcm_apitest.cc

@@ -106,12 +106,7 @@ IN_PROC_BROWSER_TEST_F(GcmApiTest, Register) {

// SHA1 of the public key provided in manifest.json.

EXPECT_EQ("26469186F238EE08FA71C38311C6990F61D40DCA",

service()->last_registered_cert());

- const std::vector<std::string>& sender_ids =

- service()->last_registered_sender_ids();

- EXPECT_TRUE(std::find(sender_ids.begin(), sender_ids.end(), "Sender1") !=

- sender_ids.end());

- EXPECT_TRUE(std::find(sender_ids.begin(), sender_ids.end(), "Sender2") !=

- sender_ids.end());

+ EXPECT_EQ("Sender1", service()->last_registered_sender_id());

}

IN_PROC_BROWSER_TEST_F(GcmApiTest, RegisterWithoutKey) {