chrome/browser/extensions/api/gcm/gcm_api.cc - Issue 183923006: [GCM] API update to allow only a single sender in registration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/gcm/gcm_api.cc

Issue 183923006: [GCM] API update to allow only a single sender in registration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/gcm/gcm_api.cc

diff --git a/chrome/browser/extensions/api/gcm/gcm_api.cc b/chrome/browser/extensions/api/gcm/gcm_api.cc

index ca57f8af9eff399d596e6390336646f32595c450..604ea36592f302b7066f43a1916e0127eae61771 100644

--- a/chrome/browser/extensions/api/gcm/gcm_api.cc

+++ b/chrome/browser/extensions/api/gcm/gcm_api.cc

@@ -129,7 +129,7 @@ bool GcmRegisterFunction::DoWork() {

GCMProfileService()->Register(

GetExtension()->id(),

- params->sender_ids,

+ params->sender_id,

jianli 2014/03/03 21:29:31 Do we want to validate if the sender ID is empty h

fgorski 2014/03/03 23:14:16 This is already done by the gcm.json, and covered

SHA1HashHexString(GetExtension()->public_key()),

base::Bind(&GcmRegisterFunction::CompleteFunctionWithResult, this));