chrome/common/extensions/api/gcm.json - Issue 183923006: [GCM] API update to allow only a single sender in registration

Unified Diff: chrome/common/extensions/api/gcm.json

Issue 183923006: [GCM] API update to allow only a single sender in registration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/services/gcm/gcm_profile_service_unittest.cc ('K') | « chrome/browser/services/gcm/gcm_profile_service_unittest.cc ('k') | chrome/test/data/extensions/api_test/gcm/functions/incognito/test.js » ('j') | google_apis/gcm/engine/registration_request.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/gcm.json

diff --git a/chrome/common/extensions/api/gcm.json b/chrome/common/extensions/api/gcm.json

index c0c77341ba4a6b016a580b43c927125bd532751b..24e3bd6726fb951ac3961c8c59dbcc21af66dcf2 100644

--- a/chrome/common/extensions/api/gcm.json

+++ b/chrome/common/extensions/api/gcm.json

@@ -16,17 +16,12 @@

{

"name": "register",

"type": "function",

- "description": "Registers the application with GCM. The registration ID will be returned by the <code>callback</code>. If <code>register</code> is called again with the same list of <code>senderIds</code>, the same registration ID will be returned.",

+ "description": "Registers the application with GCM. The registration ID will be returned by the <code>callback</code>.",

not at google - send to devlin 2014/02/28 22:36:48 The comment you removed explained what happened wh

fgorski 2014/03/03 23:14:16 Done. I've brought the statement back adjusted for

"parameters": [

{

- "name": "senderIds",

- "type": "array",

- "items": {

- "type": "string",

- "minLength": 1

- },

- "minItems": 1,

- "maxItems": 100,

+ "name": "senderId",

+ "type": "string",

+ "minLength": 1,

"description": "A list of server IDs that are allowed to send messages to the application. It should contain at least one and no more than 100 sender IDs."

not at google - send to devlin 2014/02/28 22:36:48 This description needs an overhaul.

fgorski 2014/03/03 23:14:16 Done.

{

@@ -34,7 +29,7 @@

"type": "function",

"description": "Function called when registration completes. It should check $(ref:runtime.lastError) for error when <code>registrationId</code> is empty.",

"parameters": [

- {

+ {

"name": "registrationId",

"type": "string",

"description": "A registration ID assigned to the application by the GCM."