Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1839223002: Adding alexmos@ to content/browser/frame_host/OWNERS. (Closed)

Created:
4 years, 8 months ago by nasko
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding alexmos@ to content/browser/frame_host/OWNERS. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/70834c7026029f766a4717159b4c99c8581a439b Cr-Commit-Position: refs/heads/master@{#383865}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Alphabetize. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/frame_host/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
nasko
Hey Charlie and Nick, What do you think of adding Alex to content/browser/frame_host/OWNERS? I think ...
4 years, 8 months ago (2016-03-29 22:37:26 UTC) #3
Charlie Reis
LGTM! Alex has been very thorough on reviews, and he's certainly familiar enough with that ...
4 years, 8 months ago (2016-03-29 22:46:06 UTC) #4
ncarter (slow)
lgtm++
4 years, 8 months ago (2016-03-29 22:49:39 UTC) #5
nasko
https://codereview.chromium.org/1839223002/diff/1/content/browser/frame_host/OWNERS File content/browser/frame_host/OWNERS (right): https://codereview.chromium.org/1839223002/diff/1/content/browser/frame_host/OWNERS#newcode2 content/browser/frame_host/OWNERS:2: alexmos@chromium.org On 2016/03/29 22:46:05, Charlie Reis wrote: > nit: ...
4 years, 8 months ago (2016-03-29 22:50:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839223002/20001
4 years, 8 months ago (2016-03-29 22:50:46 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 23:38:42 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 23:39:31 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/70834c7026029f766a4717159b4c99c8581a439b
Cr-Commit-Position: refs/heads/master@{#383865}

Powered by Google App Engine
This is Rietveld 408576698