Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1839213003: Further delay the title animation to avoid collision with security icon (Closed)

Created:
4 years, 8 months ago by Ian Wen
Modified:
4 years, 8 months ago
Reviewers:
Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Further delay the title animation to avoid collision with security icon Nowadays it is common that the title animation and security icon animation happen together, which renders weird visual effect. This CL postpones the title animation to avoid such collision. BUG=NONE Committed: https://crrev.com/4dd0a0e74bb425445036920817a903b0733db4e4 Cr-Commit-Position: refs/heads/master@{#384063}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 1 chunk +0 lines, -1 line 1 comment Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java View 2 chunks +3 lines, -8 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
Ian Wen
PTAL :) https://codereview.chromium.org/1839213003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java (left): https://codereview.chromium.org/1839213003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java#oldcode222 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:222: mSession = mIntentDataProvider.getSession(); This line is a ...
4 years, 8 months ago (2016-03-30 00:42:58 UTC) #2
Yusuf
lgtm
4 years, 8 months ago (2016-03-30 18:58:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839213003/1
4 years, 8 months ago (2016-03-30 19:03:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 19:57:05 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 20:05:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4dd0a0e74bb425445036920817a903b0733db4e4
Cr-Commit-Position: refs/heads/master@{#384063}

Powered by Google App Engine
This is Rietveld 408576698