Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Issue 1839213002: Move check for --disable-directwrite-for-ui switch (Closed)

Created:
4 years, 8 months ago by Ilya Kulshin
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move check for --disable-directwrite-for-ui switch This change will allow the DirectWriteFontProxyMessageFilter to bypass this switch. This is needed so that the message filter can still load fonts for renderers which might still be using DirectWrite for font rendering. BUG=594188 Committed: https://crrev.com/6c6acc660dcac0ff5f407344e2368f090bd07430 Cr-Commit-Position: refs/heads/master@{#384035}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M ui/gfx/win/direct_write.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ilya Kulshin
ptal
4 years, 8 months ago (2016-03-29 22:01:43 UTC) #2
Alexei Svitkine (slow)
lgtm
4 years, 8 months ago (2016-03-30 15:42:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839213002/1
4 years, 8 months ago (2016-03-30 18:33:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 18:41:40 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 18:43:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c6acc660dcac0ff5f407344e2368f090bd07430
Cr-Commit-Position: refs/heads/master@{#384035}

Powered by Google App Engine
This is Rietveld 408576698