Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 1839203002: [libfuzzer] improving gfx_png_image_fuzzer (Closed)

Created:
4 years, 8 months ago by aizatsky
Modified:
4 years, 8 months ago
Reviewers:
mmoroz, Oliver Chang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[libfuzzer] improving gfx_png_image_fuzzer - actually parsing png data - png dictionary BUG=584819 Committed: https://crrev.com/6d2e534692c63ff54204d3b877ef51762332ad54 Cr-Commit-Position: refs/heads/master@{#383845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M testing/libfuzzer/fuzzers/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M testing/libfuzzer/fuzzers/gfx_png_image_fuzzer.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
aizatsky
4 years, 8 months ago (2016-03-29 20:57:14 UTC) #3
Oliver Chang
lgtm
4 years, 8 months ago (2016-03-29 21:01:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839203002/1
4 years, 8 months ago (2016-03-29 21:07:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 22:11:59 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6d2e534692c63ff54204d3b877ef51762332ad54 Cr-Commit-Position: refs/heads/master@{#383845}
4 years, 8 months ago (2016-03-29 22:13:03 UTC) #10
mmoroz
Can we disable logging there anyhow https://code.google.com/p/chromium/codesearch#chromium/src/ui/gfx/image/image.cc&q=%22Unable%20to%20decode%20PNG%20for%22&sq=package:chromium&l=115 ? It seems for me that those lines ...
4 years, 8 months ago (2016-03-31 13:42:03 UTC) #11
mmoroz
4 years, 8 months ago (2016-03-31 14:12:21 UTC) #12
Message was sent while issue was closed.
On 2016/03/31 13:42:03, mmoroz wrote:
> Can we disable logging there anyhow
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/gfx/image/image...
> ?
> 
> It seems for me that those lines
>
(https://code.google.com/p/chromium/codesearch#chromium/src/base/logging.h&sq=...)
> are mixed up. FATAL is more silent level than ERROR, so I guess ERROR should
be
> default for debug and FATAL default for release. Is it possible?

However, logging::SetMinLogLevel(logging::LOG_FATAL); disabled that, I'll upload
a CL.

Powered by Google App Engine
This is Rietveld 408576698